Bug 1737997
Summary: | gitstats depends on Python 2 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Lumír Balhar <lbalhar> |
Component: | gitstats | Assignee: | Stephen Gordon <sgordon> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 31 | CC: | mhroncok, sgordon |
Target Milestone: | --- | Keywords: | Reopened, Triaged |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-10-04 20:40:05 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1698500 |
Description
Lumír Balhar
2019-08-06 12:21:50 UTC
- What is the reason for the Python2 dependency? (Is it software written in Python, or does it just provide Python bindings, or use Python in the build system or test runner?) Gitstats is written in Python, and the authors have intentionally pinned it to python2 for broad compatibility: https://github.com/hoxu/gitstats/pull/52 - What are the upstream/community plans/timelines regarding Python 3? None, as far as I can tell. - What is the guidance for porting to Python 3? (Assuming that there is someone who generally knows how to port to Python 3, but doesn't know anything about the particular package, what are the next steps to take?) I started looking at this and the most immediate issues were fairly obvious (heavy use of print statements without parentheses), but I am still teasing it apart. The alternative would be to replace it with a newer fork like https://github.com/vifactor/repostat that is python3 ready. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'. The current plan is to remove packages with dependency on Python 2 from Fedora 32 in the middle of November 2019. If you want to keep your package in Fedora after that date and you cannot port it to Python 3 yet, you need to request a FESCo exception for the package and all its Python 2 dependencies (even transitive) [1]. If you don't want to maintain it anymore, and nothing in Fedora uses it, you can retire it or just remove the Python 2 part from it (subpackage, module, bindings, etc.). If you're considering filing the exception request, let us know. We can help (for example, we can help find all the dependencies). [1] https://fedoraproject.org/wiki/Changes/RetirePython2#FESCo_exceptions As near as I can tell my best bet is to attempt to package repostat as a replacement, having it obsolete gitstats and then retire gitstats. I will attempt to have this done on the advertised timeline. Have been looking at repostat, two main issues appear to be: - The build itself is no longer driven by the Makefile which requires some restructuring of the spec. - There is an undeclared dependency on the analysis module which does not appear to be packaged today. There are also some other minor differences in terms of having moved assets around etc. but the above appear to be the main ones for me to get something working. gitstats-0-0.18.20181107git55c5c28.fc32 requires: /usr/bin/python3 python2 That is both Pythons, i.e. most likely a mistake. Fixed, thanks. (In reply to Miro Hrončok from comment #7) > Fixed, thanks. No problem. I do need to do still a bigger restructure of the package but wanted to resolve the py2 v py3 issue before it got dropped automatically. |