Bug 1738174

This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Please answer the above questions. If you don't, the package can be orphaned: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal#Information_on_Remaining_Packages

If you need any information or help, or if you need some more time, please let us know.

Please answer the above questions. If you don't, the package can be orphaned: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal#Information_on_Remaining_Packages

If you need any information or help, or if you need some more time, please let us know.

Please answer the above questions. If you don't, the package can be orphaned: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal#Information_on_Remaining_Packages

If you need any information or help, or if you need some more time, please let us know.

According to the procedure described in https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal#Information_on_Remaining_Packages the package was now orphaned. If you think it was a mistake, you can provide the answers and claim the package back.

Let us know if you need any help or just need more time.

This was unorphaned.

Please answer the above questions. If you don't, the package can be orphaned: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal#Information_on_Remaining_Packages

If you need any information or help, or if you need some more time, please let us know.

Please answer the above questions. If you don't, the package can be orphaned: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal#Information_on_Remaining_Packages

If you need any information or help, or if you need some more time, please let us know.

I suspect there is no active maintainer for scribus. Dunno if the "Design Suite" SIG is still alive.

Pete unorphaned scribus a month ago: https://pagure.io/releng/issue/8829

There are changes upstream that would enable Scribus to run with Python3 and drop Python2 support entirely. This is new, as the previous approach was dual-version capable and never worked properly.
The above changes landed in trunk only 3 days ago: https://bugs.scribus.net/view.php?id=15030

I think these changes are all that's needed to remove py2 dependencies in Scribus but I haven't double-checked.

Furthermore, I'm not sure what the best course of action is now, between:
- fetch the patches from upstream trunk and apply those changes to rawhide
- wait until a new release is done
I'd vote for the first solution.

> I'd vote for the first solution.

+1

(In reply to Dan Horák from comment #10)
> I suspect there is no active maintainer for scribus. Dunno if the "Design
> Suite" SIG is still alive.

Still alive. I will take scribus once orphaned.

Hmm, I see scribus lacked updated for a while. If the current maintainer fails to response, assign to Design Suite team i.e. myself.

Dan, Miro, Luya, FYI, the Python3-related changes that landed in 1.5.6 trunk do not apply cleanly to 1.4.x.
Maybe we should consider shipping the 1.5.6 pre-release.
1.5.x are a development candidate releases while 1.4.x are considered stable, but the current situation warrants extraordinary solutions.
Debian ships 1.5.x as scribus-ng in some of their release branches.

I've got a WIP dist-git at https://github.com/fcami/scribus-dist-git/
Specifically the following commit is able to get past the %build stage:
https://github.com/fcami/scribus-dist-git/commit/f0e683274666e23835cae666289a868eba5b7c32

The associated SOURCES file can be found at:
https://fcami.fedorapeople.org/srpms/scribus-1.5.6-free.tar.xz
and the way to generate them is documented in scribus.spec and in make-free-archive.sh

There is still work to do:
* I removed all the patches but they should be updated if still needed instead.
* %install does not work (yet).

Please let me know if you agree with the above approach.

(In reply to Luya Tshimbalanga from comment #15)
> If the current maintainer fails to response, assign to Design Suite team i.e. myself.

Note that the procedural date when this happens and the package gets orphaned is more or less the same date when we propose to remove the Python 2 packages from Fedora. I suggest that some action is taken other than waiting for no response. E-mail the maintainer maybe, ask if you can co-maintain the package? Propose a pull request and get it approved by some of the co-maintainers?


(In reply to François Cami from comment #16)
> Please let me know if you agree with the above approach.

Very much so.

Oh, I see that François Cami is a co-maintainer, so we have somebody on board \o/

(In reply to François Cami from comment #16)
> Dan, Miro, Luya, FYI, the Python3-related changes that landed in 1.5.6 trunk
> do not apply cleanly to 1.4.x.
> Maybe we should consider shipping the 1.5.6 pre-release.
> 1.5.x are a development candidate releases while 1.4.x are considered
> stable, but the current situation warrants extraordinary solutions.
> Debian ships 1.5.x as scribus-ng in some of their release branches.

Or 1.5.5. 1.4.x is outdated because of lack of complex text layout for Asian users. It seems upstream patch is applicable on 1.5.5.
> 
> I've got a WIP dist-git at https://github.com/fcami/scribus-dist-git/
> Specifically the following commit is able to get past the %build stage:
> https://github.com/fcami/scribus-dist-git/commit/
> f0e683274666e23835cae666289a868eba5b7c32


> The associated SOURCES file can be found at:
> https://fcami.fedorapeople.org/srpms/scribus-1.5.6-free.tar.xz
> and the way to generate them is documented in scribus.spec and in
> make-free-archive.sh
> 
> There is still work to do:
> * I removed all the patches but they should be updated if still needed
> instead.
> * %install does not work (yet).

I will suggest to take a look at the spec files located on:

scribus 1.5.6 snapshot
https://copr-be.cloud.fedoraproject.org/results/luya/scribus-unstable/fedora-rawhide-x86_64/01080654-scribus/scribus.spec

scribus 1.5.5
https://copr-be.cloud.fedoraproject.org/results/luya/scribus/fedora-rawhide-x86_64/00994786-scribus/scribus.spec

It includes all the needed changes and dependencies compared to the old 1.4.8, modernized macros adhering to Fedora packaging guideline.

Thanks for commenting, both of you.

Luya, thanks for your spec files, these will help.
But we cannot merge them as-is as Scribus contains some Forbidden Items.
This is why the current way to generate the archive is a two-step process:
* download the archive
* use make-free-archive.sh
and why there were patches in the first place.

I'll get this sorted out mixing your SPEC files, my changes, and possibly Debian/Arch changes as well.

Created attachment 1631736 [details]
improved make-free-archive.sh

Here is an improved and up to date make-free-archive.sh script removing the need of non-free patch and with more verbose step describing the task. Note there may be some mistakes as I am more an artist than a coder.

I had the opportunity to update the spec file and upgrading the make-free-archive script making more verbose and integrating the patches removing non-free contents. Pull Request is already filed: 
https://src.fedoraproject.org/rpms/scribus/pull-request/3

Here is the scratch result:
https://koji.fedoraproject.org/koji/taskinfo?taskID=38725398

Note the build failed on Rawhide due to Selinux issue nothing to do with Scribus.

Nice, thanks! I've merged the pull request.