Bug 1738392

Summary: Libvirt cannot get disk info of the guest installed on vmware when disk Minor device number >15
Product: Red Hat Enterprise Linux 8 Reporter: liuzi <zili>
Component: libvirtAssignee: Michal Privoznik <mprivozn>
Status: CLOSED ERRATA QA Contact: mxie <mxie>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.1CC: chhu, hhan, jdenemar, juzhou, lizhu, lmen, mprivozn, mxie, mzhan, rjones, tzheng, virt-maint, xiaodwan, xuzhang, yalzhang, yanqzhan
Target Milestone: rcKeywords: Reopened, Triaged, Upstream
Target Release: 8.6   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-7.8.0-1.module+el8.6.0+12978+7d7a0321 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2001323 (view as bug list) Environment:
Last Closed: 2022-05-10 13:18:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: 7.7.0
Embargoed:
Bug Depends On:    
Bug Blocks: 2001323    
Attachments:
Description Flags
esx6.7-rhel7.7-x86_64.vmx none

Description liuzi 2019-08-07 05:38:45 UTC 
Created attachment 1601232 [details]
esx6.7-rhel7.7-x86_64.vmx

Description of problem:
Libvirt cannot get disk info of the guest installed on vmware when guest's Minor device number >15

Version-Release number of selected component (if applicable):
libvirt-5.5.0-2.module+el8.1.0+3773+7dd501bf.x86_64
qemu-kvm-4.0.0-6.module+el8.1.0+3736+a2aefea3.x86_64

How reproducible:
100%

Steps to reproduce:
1.Prepare a guest installed on the esx6.7, and add a disk with Minor device number 16 to the guest.
# lsblk
NAME          MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT
sda             8:0    0    7G  0 disk
├─sda1          8:1    0    1G  0 part /boot
└─sda2          8:2    0    6G  0 part
  ├─rhel-root 253:0    0  5.3G  0 lvm  /
  └─rhel-swap 253:1    0  716M  0 lvm  [SWAP]
sdb             8:16   0    1G  0 disk
sr0            11:0    1 1024M  0 rom 

2.Check the guest's xml info
#  virsh -c vpx://root.73.141/data/10.73.75.219/?no_verify=1 dumpxml esx6.7-rhel7.7-x86_64
Enter root's password for 10.73.73.141:
<domain type='vmware' id='705' xmlns:vmware='http://libvirt.org/schemas/domain/vmware/1.0'>
  <name>esx6.7-rhel7.7-x86_64</name>
  <uuid>422c0152-63ab-cd03-9650-4301ae77aefd</uuid>
  <memory unit='KiB'>2097152</memory>
  <currentMemory unit='KiB'>2097152</currentMemory>
  <vcpu placement='static'>1</vcpu>
  <cputune>
    <shares>1000</shares>
  </cputune>
  <os>
    <type arch='x86_64'>hvm</type>
  </os>
  <clock offset='utc'/>
  <on_poweroff>destroy</on_poweroff>
  <on_reboot>restart</on_reboot>
  <on_crash>destroy</on_crash>
  <devices>
    <disk type='file' device='disk'>
      <source file='[esx6.7] esx6.7-rhel7.7-x86_64/esx6.7-rhel7.7-x86_64-000004.vmdk'/>
      <target dev='sda' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
    </disk>
    <controller type='scsi' index='0' model='vmpvscsi'/>
    <interface type='bridge'>
      <mac address='00:50:56:ac:3e:a1'/>
      <source bridge='VM Network'/>
      <model type='vmxnet3'/>
    </interface>
    <video>
      <model type='vmvga' vram='8192' primary='yes'/>
    </video>
  </devices>
  <vmware:datacenterpath>data</vmware:datacenterpath>
  <vmware:moref>vm-705</vmware:moref>
</domain>

Actual results:
As above description

Expected results:
Libvirt can get disk info when guest's Minor device number >15

Additional info:
1.The bug cannot be reproduced when disk's Minor number <=15,
2.The bug can be reproduced on rhel7 host.
3.The bug can be reproduced on the guests which meet the condition that one SCSI controller can control more than 16 disks.
Comment 6 RHEL Program Management 2021-03-15 07:38:13 UTC 
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.
Comment 7 Richard W.M. Jones 2021-03-15 10:29:44 UTC 
It's still a bug, what makes this "stale" bug process think otherwise?
Comment 9 Michal Privoznik 2021-08-03 18:42:10 UTC 
Patches posted upstream:

https://listman.redhat.com/archives/libvir-list/2021-August/msg00038.html
Comment 10 Michal Privoznik 2021-08-16 12:24:59 UTC 
Merged upstream as:

32f7db0989 vmx: Support super wide SCSI bus
5c254bb541 conf: Store SCSI bus length in virDomainDef
48344c640f vmx: Drop needless check in virVMXParseDisk()
d628c5ded1 vmx: Rework disk def allocation
de1829059a vmx2xmltest: Add a test case
5e16038284 vmx: Fill virtualHW.version to ESX version mapping

v7.6.0-133-g32f7db0989
Comment 11 John Ferlan 2021-09-05 14:19:51 UTC 
Move to RHEL since RHEL-AV will only be a rebuild of RHEL starting w/ 8.6.0
Comment 12 mxie@redhat.com 2021-10-21 11:30:55 UTC 
Test the bug with libvirt-client-7.8.0-1.module+el8.6.0+12978+7d7a0321.x86_64

Steps:
1.Prepare a guest with more than 16 disks on VMware ESXi host, then use virsh to dump the libvirtxml of the guest
# virsh -c vpx://root.198.169/data/10.73.199.217/?no_verify=1 dumpxml Auto-esx7.0-rhel8.5-with-more-than-16disks
Enter root's password for 10.73.198.169: 
<domain type='vmware' xmlns:vmware='http://libvirt.org/schemas/domain/vmware/1.0'>
  <name>Auto-esx7.0-rhel8.5-with-more-than-16disks</name>
  ....
    </disk>
    <disk type='file' device='disk'>
      <source file='[datastore1] Auto-esx7.0-rhel8.5-with-16disks/Auto-esx7.0-rhel8.5-with-16disks_2.vmdk'/>
      <target dev='sdb' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='1'/>
    </disk>
    <disk type='file' device='disk'>
      <source file='[datastore1] Auto-esx7.0-rhel8.5-with-16disks/Auto-esx7.0-rhel8.5-with-16disks_3.vmdk'/>
      <target dev='sdc' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='2'/>
    </disk>
    .....
    .....
    <disk type='file' device='disk'>
      <source file='[datastore1] Auto-esx7.0-rhel8.5-with-16disks/Auto-esx7.0-rhel8.5-with-16disks_20.vmdk'/>
      <target dev='sdt' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='20'/>
    </disk>
    <disk type='file' device='disk'>
      <source file='[datastore1] Auto-esx7.0-rhel8.5-with-16disks/Auto-esx7.0-rhel8.5-with-16disks_21.vmdk'/>
      <target dev='sdu' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='21'/>
    </disk>
    .....

Result:
    Virsh can dump all disks(more than 16) of guest from VMware
Comment 15 mxie@redhat.com 2021-10-21 14:41:21 UTC 
Verify the bug with libvirt-client-7.8.0-1.module+el8.6.0+12978+7d7a0321.x86_64

Steps:
1.Prepare a guest with more than 16 disks on VMware ESXi host, then use virsh to dump the libvirtxml of the guest
# virsh -c vpx://root.198.169/data/10.73.199.217/?no_verify=1 dumpxml Auto-esx7.0-rhel8.5-with-more-than-16disks
Enter root's password for 10.73.198.169: 
<domain type='vmware' xmlns:vmware='http://libvirt.org/schemas/domain/vmware/1.0'>
  <name>Auto-esx7.0-rhel8.5-with-more-than-16disks</name>
  ....
    </disk>
    <disk type='file' device='disk'>
      <source file='[datastore1] Auto-esx7.0-rhel8.5-with-16disks/Auto-esx7.0-rhel8.5-with-16disks_2.vmdk'/>
      <target dev='sdb' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='1'/>
    </disk>
    <disk type='file' device='disk'>
      <source file='[datastore1] Auto-esx7.0-rhel8.5-with-16disks/Auto-esx7.0-rhel8.5-with-16disks_3.vmdk'/>
      <target dev='sdc' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='2'/>
    </disk>
    .....
    .....
    <disk type='file' device='disk'>
      <source file='[datastore1] Auto-esx7.0-rhel8.5-with-16disks/Auto-esx7.0-rhel8.5-with-16disks_20.vmdk'/>
      <target dev='sdt' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='20'/>
    </disk>
    <disk type='file' device='disk'>
      <source file='[datastore1] Auto-esx7.0-rhel8.5-with-16disks/Auto-esx7.0-rhel8.5-with-16disks_21.vmdk'/>
      <target dev='sdu' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='21'/>
    </disk>
    .....

Result:
    Virsh can dump all disks(more than 16) of guest from VMware, move the bug from ON_QA to VERIFIED
Comment 17 errata-xmlrpc 2022-05-10 13:18:34 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: virt:rhel and virt-devel:rhel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1759