Bug 1738592

Summary: [docs] FFU 10 > 13 guide needs to set "ceph::profile::params::osds" to "{}"
Product: Red Hat OpenStack Reporter: John Fulton <johfulto>
Component: documentationAssignee: ndeevy <ndeevy>
Status: CLOSED CURRENTRELEASE QA Contact: RHOS Documentation Team <rhos-docs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 13.0 (Queens)CC: dcadzow, dmacpher, gfidente, ndeevy, pkundal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-21 07:40:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description John Fulton 2019-08-07 14:14:08 UTC
The Fast Forward Upgrades document, chapter section 5.9. Preparing for Ceph Storage or HCI node upgrades [1], needs to add an additional line of syntax to its example in order to prevent the problem reported in bug 1720281.
 
I will supply draft copy in my next update.

[1] https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/13/html/fast_forward_upgrades/assembly-preparing_for_overcloud_upgrade#preparing_for_ceph_storage_or_hci_node_upgrades

Comment 1 John Fulton 2019-08-07 14:14:32 UTC
*** Bug 1720281 has been marked as a duplicate of this bug. ***

Comment 2 John Fulton 2019-08-07 14:20:11 UTC
Step 3 states the following:

"For director-managed Ceph Storage clusters, use the new CephAnsibleDisksConfig parameter to define how your disks are mapped. Previous versions of Red Hat OpenStack Platform used the ceph::profile::params::osds hieradata to define the OSD layout. Convert this hieradata to the structure of the CephAnsibleDisksConfig parameter."

The above should stay as it is and I'm only mentinoning it to give context as to where the change should be. 

The above also then goes on to state the following:

"""
Convert the hieradata in the following way with the CephAnsibleDisksConfig parameter:

parameter_defaults:
  ExtraConfig: {}
  CephAnsibleDisksConfig:
    devices:
    - /dev/sdb
    - /dev/sdc
    - /dev/sdd
    dedicated_devices:
    - /dev/sdn
    - /dev/sdn
    - /dev/sdn
    journal_size: 512
    osd_scenario: non-collocated
"""


The above in triple quotes should be changed to the following:


"""
Convert the hieradata in the following way with the CephAnsibleDisksConfig parameter and set ceph::profile::params::osds to {}:

parameter_defaults:
  CephAnsibleDisksConfig:
    devices:
    - /dev/sdb
    - /dev/sdc
    - /dev/sdd
    dedicated_devices:
    - /dev/sdn
    - /dev/sdn
    - /dev/sdn
    journal_size: 512
    osd_scenario: non-collocated
  ExtraConfig:
    ceph::profile::params::osds: {}
"""

Comment 3 Giulio Fidente 2019-08-07 14:25:44 UTC
Also note that there might be in the docs other chapters where we suggest to "remove" pre-existing ceph::profile::params::osds keys from the heat environment files when upgrading to OSP13. The problem is that *removing* will not be sufficient, the key should be kept and set to {} instead. This needs to be reviewed especially in the FFWD guide.