Bug 1738597
Summary: | [wayland] firefox toolbar layout wrong at startup - wrong screen is used | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> | ||||||||
Component: | firefox | Assignee: | Jan Horak <jhorak> | ||||||||
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | unspecified | Docs Contact: | |||||||||
Priority: | unspecified | ||||||||||
Version: | 31 | CC: | 0xalen+redhat, anto.trande, gecko-bugs-nobody, jhorak, john.j5live, kengert, laurent, pjasicek, rhughes, rstrode, sandmann, stransky | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2020-11-24 16:47:43 UTC | Type: | Bug | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 1054334 | ||||||||||
Attachments: |
|
Description
Hans de Goede
2019-08-07 14:24:24 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. I'm afraid I don't quite understand. Can you please try to create a screencast of the bug? How-to is here: https://help.gnome.org/users/gnome-help/stable/screen-shot-record.html.en Created attachment 1632948 [details]
screencast of the bug
Hi Martin,
I've added a screencast of the bug. In the screencast you can see a similar behaviour as described by Hans, except that I don't need to resize the Firefox window to get my toolbar layout restored (I use "Customize Toolbar..." button).
I don't known why the screencast flickers. When I start the screencast with the ctrl-alt-shift-R shortcut, my framerate drops well below 1 fps.
Ahh I think I understand now - it looks like small monitor is reported. I see you use multi-monitor scenario, perhaps Firefox takes (wrongly) the primary screen which is smaller than the actual one. I guess if you turn-off your the second screen and have opened only one you get the correct behavior, am I right? Thanks. Jan, any idea here? (In reply to Martin Stransky from comment #5) > Ahh I think I understand now - it looks like small monitor is reported. Yes it seems that firefox uses a layout which is intended for small monitors. > I see you use multi-monitor scenario, perhaps Firefox takes (wrongly) the > primary screen which is smaller than the actual one. > I guess if you turn-off your the second screen and have opened only one you > get the correct behavior, am I right? I also have 2 monitors, but they are both 1920x1080, so I do not believe that this is the case. My feeling is that Firefox sometimes (often) checks the window size to see if it needs to use the layout for small monitors *before* the window has been assigned a size by the compositor. As I explained when resizing if I make the window smaller (less wide) then the layout stays the same; but as soon as I make it one pixel wider (even if less wide then the starting width) then things correct itself. I have the feeling the resize handler for some reason (expensive?) only redo-s the check if it needs to stop using the "mini" layout for the toolbars if the window has gotten larger and it skips it when it receives the initial size. Just doing the check when the initial size is received will probably fix / workaround the race here. Going to customize and then exiting indeed is another workaround. I was able to reproduce the bug with the second screen turned-off. I use a laptop docked on a docking station with two monitors pluged on the docking station. The laptop monitor is not used (the laptop is closed). The two pluged monitors are both 1920x1200. Jan, can you look at it please? There may be wrong screen size reported or so? Hans, can you run firefox on single monitor setup with WAYLAND_DEBUG=1 env variable set (when the bug is exhibited) and attach the log here? Thanks. Err sorry I meant Laurent. Created attachment 1633204 [details]
wayland_debug_with_bug
Created attachment 1633205 [details]
wayland_debug_without_bug
I've attached 2 wayland log files: the first (wayland_debug_with_bug) when Firefox is started and the bug appeared, and the second (wayland_debug_without_bug) when Firefox is started and the toolbar is displayed as expected. This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |