Bug 1738643

Summary: [v2v][Regression] Can not add conversion host due to playbook errors
Product: Red Hat CloudForms Management Engine Reporter: Yadnyawalk Tale <ytale>
Component: V2VAssignee: Fabien Dupont <fdupont>
Status: CLOSED CURRENTRELEASE QA Contact: Shveta <sshveta>
Severity: urgent Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: urgent    
Version: 5.11.0CC: bthurber, istein, simaishi, smallamp, sshveta, tgolembi
Target Milestone: GAKeywords: Regression
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: v2v
Fixed In Version: 5.11.0.19 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-13 15:01:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1693994    

Description Yadnyawalk Tale 2019-08-07 17:24:43 UTC
Description of problem:
Can not add conversion host due to playbook errors


Version-Release number of selected component (if applicable):
5.11.0.18.20190806180636_1dd6378


How reproducible:
100%


Steps to Reproduce:
1. Add providers
2. Try to conversion host


Actual results:
Getting playbook errors in evm.log (conversion logging)


Expected results:
Conversion host should just work 


Additional info:
1. Last time it worked in 5.11.0.17 and I am still able to add same conversion host in same version. 

2. When I ran playbook manually I am getting following error - 
```
[root@dhcp-8-197-190 playbooks]# ansible-playbook /usr/share/v2v-conversion-host-ansible/playbooks/conversion_host_check.yml --inventory redacted-host.redhat.com, --become --extra-vars="ansible_ssh_common_args='-o StrictHostKeyChecking=no'" --user root --private-key /tmp/ansible_key20190807-7858-jg519d --extra-vars '{"v2v_host_type":"rhevm","v2v_transport_method":"vddk"}'
ERROR! the role 'oVirt.v2v-conversion-host' was not found in /usr/share/v2v-conversion-host-ansible/playbooks/roles:/etc/ansible/roles:/var/www/miq/vmdb/content/ansible_consolidated/roles:/usr/share/v2v-conversion-host-ansible/playbooks

The error appears to be in '/usr/share/v2v-conversion-host-ansible/playbooks/conversion_host_check.yml': line 5, column 7, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

  roles:
    - role: oVirt.v2v-conversion-host
      ^ here
```

3. Initially I thought may be it is due to diff package but both 5.11.0.17 and .18 contain same v2v-conversion-host-ansible-1.14.2-1.el8ev.noarch package.

Comment 4 Tomáš Golembiovský 2019-08-07 18:34:35 UTC
Looks like a configuration change in Ansible. It is no longer looking in /usr/share/ansible/roles. What was the package version in  5.11.0.17?

In  5.11.0.18 on your appliance I see: ansible-2.8.3-1.el8ae.noarch

Comment 7 Fabien Dupont 2019-08-08 07:02:05 UTC
So, the problem with the roles_path comes from /root/.ansible.cfg that overrides it.

On the 5.11.0.17 appliance, the name of the config section was wrong, so the config didn't apply. It's been fixed on Aug 1st by https://github.com/ManageIQ/manageiq-appliance/pull/249 and this generates the regression.

I created a PR to add the default path to roles_path: https://github.com/ManageIQ/manageiq-appliance/pull/252

Comment 8 CFME Bot 2019-08-08 22:01:30 UTC
New commit detected on ManageIQ/manageiq-appliance/ivanchuk:

https://github.com/ManageIQ/manageiq-appliance/commit/9f584523936132cb382f205b46b9e07b418ba1f4
commit 9f584523936132cb382f205b46b9e07b418ba1f4
Author:     Nick Carboni <ncarboni>
AuthorDate: Thu Aug  8 10:15:57 2019 -0400
Commit:     Nick Carboni <ncarboni>
CommitDate: Thu Aug  8 10:15:57 2019 -0400

    Merge pull request #252 from fdupont-redhat/fix_ansible_roles_path

    Add default roles paths to .ansible.cfg

    (cherry picked from commit 341f0d37742458a65f5df50cd45aab953648e651)

    https://bugzilla.redhat.com/show_bug.cgi?id=1738643

 LINK/root/.ansible.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 9 Fabien Dupont 2019-08-11 10:46:28 UTC
*** Bug 1739865 has been marked as a duplicate of this bug. ***

Comment 10 Shveta 2019-08-16 06:25:11 UTC
Able to add conversion hosts in 5.11.0.19.20190813184334_ed72c9f