Bug 1738802
| Summary: | python-igor depends on Python 2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lumír Balhar <lbalhar> |
| Component: | python-igor | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 31 | CC: | zbyszek |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-11-07 10:16:52 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1698500, 1739520 | ||
|
Description
Lumír Balhar
2019-08-08 08:27:08 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. Please answer the above questions. If you don't, the package can be orphaned: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal#Information_on_Remaining_Packages If you need any information or help, or if you need some more time, please let us know. The package needs some work to make python3 support fully functional. I tried to make a PR a few years ago, but there were some issues with bytes formatting that never got resolved properly. Help would be welcome. I'll get to this at some point... Thanks for the info. The current plan is to remove packages with dependency on Python 2 from Fedora 32 in the middle of November 2019. If you want to keep your package in Fedora after that date and you cannot port it to Python 3 yet, you need to request a FESCo exception for the package and all its Python 2 dependencies (even transitive) [1]. If you don't want to maintain it anymore, and nothing in Fedora uses it, you can retire it or just remove the Python 2 part from it (subpackage, module, bindings, etc.). If you're considering filing the exception request, let us know. We can help (for example, we can help find all the dependencies). [1] https://fedoraproject.org/wiki/Changes/RetirePython2#FESCo_exceptions Hello. I'd like to help you here so I did some testing and here is my plan. I've read the latest build log and it seems that the tests are failing with both Pythons just because of different formatting (newer numpy, "b" prefix for bytes objects, "L" suffix for integers). Source code itself looks Python 3 compatible and I did also some tests of CLI tools igorpackedexperiment and igorbinarywave with the test data from upstream and Python 3 and everything looks good. So, the plan is: 1. Move igorpackedexperiment and igorbinarywave to python3- subpackage, change shebangs 2. Remove python2- subpackage The optional third step could be to port all tests to Python 3 (downstream). I can do that but it depends on you whether you want to maintain a patch like this or not. If you agree, I'll prepare a PR. Sure, if you can prep something that mostly works, I'll be happy to have it. (The package does not change upstream, so any local patch will not require "maintenance". And I'm pretty sure upstream will be happy to take it anyway.) Pull request: https://src.fedoraproject.org/rpms/python-igor/pull-request/2 I'll take a look at the tests soon. Patch for doctests: https://src.fedoraproject.org/rpms/python-igor/pull-request/3 It seems that everything works here. Thank you! |