Bug 173897

Thank you for packaging these - I've been looking for good Hebrew fonts (I'm
learning it) - found a few, and found some expensive nice commercial ones.
Anyway, these look nice.

-=-
Back on topic - some suggestions:

1) Please use a full url path to the tarballs - IE

Source0: http://culmus.sourceforge.net/fancy/comix.tar.gz

2) Please install them into their own directory, rather than a directory owned
by a core font package.
perhaps %{_datadir}/fonts/hebrew-fancy

That will also remove the need for explicit dependency on hebrew-fonts

3) FC-5 uses fonts.cache-2 - so its easiest to touch and ghost both

touch $RPM_BUILD_ROOT%{_datadir}/hebrew-fancy/fonts.cache-{1,2}

Then in the %files section - ghost both of them.

IE
%ghost %{_datadir}/fonts/hebrew-fancy/fonts.cache-1
%ghost %{_datadir}/fonts/hebrew-fancy/fonts.cache-2

4)

%post
fc-cache %{_datadir}/fonts

I *think* that is incorrect - may work in fc4, but I believe it doesn't in fc5.
I believe in fc5 you have to specify the directory. IE

%post
fc-cache %{_datadir}/fonts/hebrew-fancy

The %postun is I believe correct.

%defattr(-,root,root)

Please change that to

%defattr(-,root,root,-)

-=-
A Hebrew summary and description would be nice, but not required.

Good luck with your Hebrew studies; you might find my verb conjugator 
useful http://wassist.cs.technion.ac.il/~danken/cgi-bin/cilla.cgi.

I believe that Maxim Iorsh, who drew the fonts, deserves all your thanks.

I did what you asked, and hope it's ok (no idea what is this %ghost...
should browse MaximumRPM).
Do note that I copied the %post script from FC4 fonts-hebrew package.
One should make sure it is correct in FC5.

.spec and SRPM are updated
http://ivrix.org.il/redhat/fonts-hebrew-fancy-0.101-2.src.rpm

Formal review coming (including fc5 test)

What %ghost does is mark a file such that it is not actually installed by the
rpm but is owned by the rpm if it exists.

This allows the proper program (in this case) fc-cache to be responsible for
creating the file, but it is owned by the rpm - so that when the rpm is removed,
 the ghosted file is removed as if the rpm had been who put it there in the
first place.

I don't know if Maximum rpm talks about it or not. I think the Red Hat RPM Guide
(which I believe either is or shortly will be available for free) does.

Reviewed per http://fedoraproject.org/wiki/PackageReviewGuidelines

Good:
* rpmlint clean
* Package name appropriate
- upstream distributes as a series of tarballs, but the source of these
- fonts are grouped together as fancy
- These fonts are from the same project as the Core package fonts-hebrew
* Spec file name matches src.rpm name
* Package meets packaging guidelines
* Specified License (GPL) matches project page and license provided with source
* License in %doc
* Spec file written in American English, Legible
* Sources match upstream md5sum
* spec file works
* No BuildRequires (thus none from exceptions or redundant)
* No locale files
* no shared libraries
* No use of Prefix:
* No duplicates
* Appropriate permissions
* Proper %clean
* consistent use of macros
* contains permisable content
* No need for separate docs package
* files in %doc not necessary for runtime
* No devel/library/etc to worry about
* Contains summary/description for Hebrew
* Sane scriptlets
* Works in FC4 and FC5

Approved

Package Change Request
======================
Package Name: culmus-fancy-fonts
Owners: danken

according to bug 477387 I need (among other things) to rename fonts-hebrew-fancy to culmus-fancy-fonts. Is this the place to ask for that (and inclusion of the new name in F11)?

No. You need to submit a new review request for the newly named package. ;) 
Once it's approved and added, you can go back and mark the current name dead.