| Summary: | Review Request: opensbi - RISC-V Open Source Supervisor Binary Interface (OpenSBI) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | itamar, package-review, pbonzini |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-09-20 09:26:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Richard W.M. Jones
2019-08-08 15:12:47 UTC
Spec URL: http://oirase.annexia.org/reviews/opensbi/opensbi.spec SRPM URL: http://oirase.annexia.org/reviews/opensbi/opensbi-0.4-1.gitc1b9dd3a.fc30.src.rpm Description: RISC-V Open Source Supervisor Binary Interface (OpenSBI) Fedora Account System Username: rjones Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36862762 Please install the files in /usr/share rather than /usr/lib. Can the .a files be used in a Linux program or are they used to build more firmware? If the former, they should probably reside in /usr/lib and in a riscv package. If the latter, they should be in a noarch package and should stay in /usr/share. Either way, binaries that are used by QEMU should be in a subpackage. The new package does install the files in /usr/share/opensbi: $ rpm -qlp ~/rpmbuild/RPMS/noarch/opensbi-0.4-1.gitc1b9dd3a.fc30.noarch.rpm /usr/share/opensbi /usr/share/opensbi/opensbi-riscv64-sifive_u-fw_jump.bin /usr/share/opensbi/opensbi-riscv64-virt-fw_jump.bin It will require us to add symlinks from /usr/share/qemu into the qemu package. Good point about the lib*.a files. I forgot that they're RISC-V libraries. I'm not totally sure why we would need to package them (or the header files). I wonder if we should just drop the -devel package altogether. David? This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. lets finish this. Unsetting NEEDINFO. I discussed this bug with David Abdurachmanov last week and we will attempt to add this package soon, and at a later version. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. I'm going to close this as I'm not sure if we really need it. qemu is currently shipping the required firmware. However in case anyone takes it over I have left my latest work on this package here: http://git.annexia.org/?p=fedora-reviews.git;a=tree;f=opensbi |