Bug 1739336

Summary:	Multiple disconnect events being propagated for the same child
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	rpc	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	5	CC:	amgad.saleh, bugs, ravishankar, rgowdapp
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1716979	Environment:
Last Closed:	2019-08-12 07:19:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1703423, 1716979
Bug Blocks:	1739334, 1739335, 1759832

Description Ravishankar N 2019-08-09 05:02:48 UTC

+++ This bug was initially created as a clone of Bug #1716979 +++

+++ This bug was initially created as a clone of Bug #1703423 +++

Description of problem:
Issue was reported upstream by a user via https://github.com/gluster/glusterfs/issues/648

I'm seeing that if I kill a brick in a replica 3 system, AFR keeps getting child_down event repeatedly for the same child. This seems to be a regression in behaviour as it does not occur in rhgs-3.4.0. In 3.4.0, I get exactly one GF_EVENT_CHILD_DOWN for 1 disconnect.

Version-Release number of selected component (if applicable):
rhgs-3.5 branch (source install)

How reproducible:
Always.

Steps to Reproduce:
1. Create a replica 3 volume and start it.
2. Put  a break point in __afr_handle_child_down_event() in glustershd process.
3. Kill any one brick.

Actual results:
The break point keeps getting hit once every 3 seconds or so repeatedly.

Expected results:
Only 1 event per one disconnect.

Additional info:
I haven't checked if the same happens for GF_EVENT_CHILD_UP as well. I think this is regression that needs to be fixed. If this is not a bug please feel free to close stating why.

Comment 1 Worker Ant 2019-08-09 05:05:17 UTC

REVIEW: https://review.gluster.org/23181 (protocol/client: propagte GF_EVENT_CHILD_PING only for connections to brick) posted (#1) for review on release-5 by Ravishankar N

Comment 2 Worker Ant 2019-08-12 07:19:58 UTC

REVIEW: https://review.gluster.org/23181 (protocol/client: propagte GF_EVENT_CHILD_PING only for connections to brick) merged (#1) on release-5 by Ravishankar N