Bug 1739780
| Summary: | Review Request: poetry - Python dependency management and packaging made easy | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-08-13 10:15:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1739777, 1739779 | ||
| Bug Blocks: | |||
|
Description
Fabio Valentini
2019-08-10 11:47:43 UTC
Taking this review. > Requires: python3-%{pypi_name}
This should be a strictly versioned dependency, since you're splitting it between the Pythom module and the program.
Is there any particular value in doing this over just letting it all be in the "poetry" binary package?
(In reply to Neal Gompa from comment #2) > > Requires: python3-%{pypi_name} > > This should be a strictly versioned dependency, since you're splitting it > between the Pythom module and the program. Right. I will fix this. Tomorrow ... > Is there any particular value in doing this over just letting it all be in > the "poetry" binary package? Not particularly. But I know that pyproject.toml actually uses API form the poetry python package and not the poetry binary itself. Now I need to sleep. I made the dependency from poetry -> python3-poetry explicitly versioned. Also relaxed the dependency on pyrsistent so the package can actually be installed on rawhide as well as f30. Review notes: [x]: Follows Fedora Packaging Guidelines [x]: Follows Fedora Python Packaging Guidelines [x]: Package includes license file and has correct tag [x]: Package builds and installs properly PACKAGE APPROVED (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/poetry Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1354153 Submitted for f30: https://bodhi.fedoraproject.org/updates/FEDORA-2019-458e2b6e9e |