Bug 1739867
| Summary: | Broken support in libdnf of zchunk metadata after rebuilt for librepo 1.10.5 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ihor <ihorchyhin> |
| Component: | libdnf | Assignee: | rpm-software-management |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | high | Docs Contact: | |
| Priority: | medium | ||
| Version: | 30 | CC: | dmach, grumpey0, jimis, jmracek, jonathan, jrohel, mblaha, mdomonko, pkratoch, rpm-software-management, taocrismon |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | libdnf-0.35.2-4.fc30 libdnf-0.35.3-5.fc31 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-09-19 01:30:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ihor
2019-08-11 11:38:29 UTC
It appears that we don't properly enable zchunk support when building librepo on fedora: https://github.com/rpm-software-management/librepo/blob/385e2ced1083cac0bcb19e30500311f6923e6dfc/librepo.spec#L131 This requires a closer look, however. Marking as Triaged for now. So it seems the conditional behaves exactly the opposite way; it defines WITH_ZCHUNK (with the OFF value being irrelevant here) which is then checked here: https://github.com/rpm-software-management/librepo/pull/156/files So, what's happening is that this header in the last comment is provided by librepo, but libdnf doesn't set WITH_ZCHUNK when building, so the conditional isn't actually being set when libdnf is built. Here's a PR to fix it in libdnf: https://github.com/rpm-software-management/libdnf/pull/777 And here are PRs to pull in the fix into the current F30, F31 and Rawhide packages: https://src.fedoraproject.org/rpms/libdnf/pull-request/4 - Rawhide https://src.fedoraproject.org/rpms/libdnf/pull-request/5 - F31 https://src.fedoraproject.org/rpms/libdnf/pull-request/6 - F30 I've tested the fix on my F30 system, and have done scratch builds in F30 and Rawhide, so I don't anticipate any problems with the fix FEDORA-2019-fb54fb2b81 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-fb54fb2b81 FEDORA-2019-7d72d1e7a5 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7d72d1e7a5 libdnf-0.35.2-4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-fb54fb2b81 libdnf-0.35.3-5.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7d72d1e7a5 libdnf-0.35.2-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. libdnf-0.35.3-5.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. |