Bug 1739899
| Summary: | bleachbit fails to install in Fedora rawhide | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | bleachbit | Assignee: | Audrey Yeena Toskin <audrey> |
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | urgent | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 31 | CC: | audrey, awilliam, pviktori |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-08-31 07:39:11 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1700324, 1690439 | ||
|
Description
Miro Hrončok
2019-08-11 21:24:37 UTC
Weird. If it won't install because of missing dependencies, I should think it would also have failed to build in Koji :/ I may have to retire the package after all, but I'm hoping it won't come to that. I think the deadline for Python2 packages is January 2020? The Bleachbit team upstream is working on porting to GTK3 and Python3, but there's currently no estimate on when it will be ready. > Weird. If it won't install because of missing dependencies, I should think it would also have failed to build in Koji :/ Maybe it doesn't build either, this install failure is new. > I think the deadline for Python2 packages is January 2020? mid November 2019 in Fedora 32, however this is not automatic Python 2 removal, this is a dependency being retired. You can still unretire the dependency if needed. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. Hmm, I wasn't sure how to deal with this, since I don't want BleachBit removed from Fedora entirely, just for the distro releases where Python2 has been removed, and only until the BleachBit developers finish the Python3 conversion... So I filed an issue with releng on Pagure. https://pagure.io/releng/issue/8636 The right place for this discussion is this bug. Python 2 is not being removed right now. gnome-python2 was, but you should contact the maintainers rather than releng. Releng monitors the FTBFS, but the *maintainers* should know how to make the package build. Also, releng is not removing Python 2 packages specifically -- it removes those that fail to build, or those that maintainers ask to be retired. The gnome-python2 FTBFS bug is here: https://bugzilla.redhat.com/show_bug.cgi?id=1735278 From that bug, it seems that it doesn't have active maintainers. Do you want to take it and fix it? I can take a look. I'm not sure why gnome-python2 is failing to build either, though. See https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal#Removing_non-installable_packages_from_the_distro "Packages still failing to install due to a missing Python 2 dependency will be retired at Beta Freeze, assuming they have a Bugzilla bug open for at least 2 weeks. The package maintainer may postpone this retirement to the Final Freeze by promising to fix it until then." Let me know if this package shall not be retired yet. The beta freeze is at 2019-08-29, the final freeze is at 2019-10-08. I commented on Bug #1735278 about how I can't figure out why gnome-python2 is failing to build... But I just came up with one theory: It seems to me like fedpkg is looking for a file directly under %{buildroot}, even though the paths are prefixed with %{python2_sitearch}. So, could %{python2_sitearch} be parsing as an empty string because the variable was deleted? Would that need to be re-added to the spec for it to work? (In reply to Andrew Toskin from comment #9) > I commented on Bug #1735278 about how I can't figure out why gnome-python2 > is failing to build... But I just came up with one theory: It seems to me > like fedpkg is looking for a file directly under %{buildroot}, even though > the paths are prefixed with %{python2_sitearch}. So, could > %{python2_sitearch} be parsing as an empty string because the variable was > deleted? > > Would that need to be re-added to the spec for it to work? Is this in? BuildRequires: python2-devel Anyway, please answer: Let me know if this package shall not be retired yet. In the gnome-python2 spec (when checking out commit cf0ce31, from before it was retired), I see
BuildRequires: python2-devel >= %{python_version}
with
%define python_version 2.3.0
So that doesn't seem to be the problem.
I don't really *want* to retire the package, especially if it will likely mean having to do a new package review when the upstream finally finishes porting to Python 3. But unless we can make an exception for all of BleachBit's Python 2 dependencies, *and* figure out how to get `gnome-python2` building again, I figured retiring it would be necessary.
You'd probably know better than me what's best in this situation.
I'd retire it. You can ping me for the package review when the tme comes and I gladly help you. Okay, I agree. I'll let the package automatically retire, and in the meanwhile keep an eye on the upstream. Retired the package in master and f31. Let me know once it is ready for re-review. Requesting a freeze exception based on https://pagure.io/fesco/issue/2216#comment-593925 Unproposing per https://pagure.io/fesco/issue/2216#comment-594033 . Please only propose bugs where an update was actually pending before the 29th, unless there is a more urgent reason why that package specifically should get an FE. I've verified that the package is gone from the fedora repo. Thanks and sorry for panicking. |