Bug 174065

Summary: Review Request: jabberd server
Product: [Fedora] Fedora Reporter: Adrian Reber <adrian>
Component: Package ReviewAssignee: Aurelien Bompard <gauret>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list, scop
Target Milestone: ---Flags: huzaifas: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://jabberd.jabberstudio.org/2/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-11-28 07:38:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 159810, 163779    

Description Adrian Reber 2005-11-24 08:59:52 UTC
Spec Name or Url: already in CVS

jabberd has been imported into CVS but there hasn't been a formal approval, therefore I am submitting a request for package review. See https://www.redhat.com/archives/fedora-extras-list/2005-March/msg00057.html for details on the reviews until now

Description: The jabberd project aims to provide an open-source server implementation of the
Jabber protocols for instant messaging and XML routing. The goal of this
project is to provide a scalable, reliable, efficient and extensible server
that provides a complete set of features and is up to date with the latest
protocol revisions.

Comment 1 Aurelien Bompard 2005-11-26 23:13:20 UTC
Looks good. A few comments :
* File listed twice: /etc/jabberd/server.pem
* Missing dependancy on /sbin/service for %post, %postun and %preun (initscripts
package)
* don't userdel jabber on removal, to avoid files belonging to nobody


Comment 2 Aurelien Bompard 2005-11-27 12:04:15 UTC
Jabberd is enabled at boot by default. We usually don't enable network-listening
daemons by default. In the init script, just change this :
-chkconfig: 2345 85 15
+chkconfig: - 85 15
The user can enable it with "chkconfig jabberd on" afterwards if needed.

Comment 3 Adrian Reber 2005-11-27 12:39:40 UTC
Thanks for the review.

I have checked in the changes required for the comment #1 and for comment #2.

Comment 4 Aurelien Bompard 2005-11-27 21:23:42 UTC
Review for release 0.s10.8:
* RPM name is OK
* Source jabberd-2.0s10.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of jabberd looks OK
* File list of jabberd looks OK
* Works fine
APPROVED.

Funny thing: it crashes rpmlint. Ville, do you want to look at that ? Here's the
binary rpm in case you can't reproduce:
http://gauret.free.fr/fichiers/rpms/fedora/jabberd-2.0-0.s10.8.i386.rpm

Comment 5 Ville Skyttä 2005-11-27 22:17:28 UTC
(In reply to comment #4)
> Funny thing: it crashes rpmlint. Ville, do you want to look at that ?

Looked, found the bug, fix will be in the next release.  Thanks for the heads up.

Comment 6 Adrian Reber 2005-11-28 07:38:23 UTC
Thanks. jabberd has been successfully built in devel.

Comment 7 Rudi Chiarito 2006-01-20 23:16:33 UTC
Is this supposed to appear in the FC3/4 repositories? It has been built for
devel only.

Comment 8 Adrian Reber 2006-01-23 08:01:50 UTC
> Is this supposed to appear in the FC3/4 repositories? It has been built for
> devel only.

Not is hasn't. This is also available for FC4.

Comment 9 Adrian Reber 2008-10-08 09:21:12 UTC
New Package CVS Request
=======================
Package Name: jabberd
Short Description: OpenSource server implementation of the Jabber protocols
Owners: adrian bernie
Branches: F-10
InitialCC:

Comment 10 Huzaifa S. Sidhpurwala 2008-10-08 09:41:15 UTC
jabberd is now branched for F-10