Bug 1741243

Summary: Creating a filter with a blank field triggers a 500 error
Product: Red Hat CloudForms Management Engine Reporter: Ryan Spagnola <rspagnol>
Component: ReportingAssignee: Yuri Rudman <yrudman>
Status: CLOSED EOL QA Contact: Gaurav Talreja <gtalreja>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.11.0CC: dmetzger, hstastna, jocarter, mfeifer, mshriver, obarenbo, simaishi, smallamp, yrudman
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.12.0Flags: mfeifer: mirror+
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1761525 1784097 (view as bug list) Environment:
Last Closed: 2020-03-25 18:02:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1761525, 1784097    
Attachments:
Description Flags
screenshot none

Description Ryan Spagnola 2019-08-14 14:52:45 UTC 
Description of problem:


Version-Release number of selected component (if applicable):
5.11.0.18

How reproducible:
Always

Steps to Reproduce:
1. Create a filter under Services > My Services > Services
2. Set filter to Field
3. Service:Custom 1 = [blank field]
4. Save

Actual results:
500 internal server error

Expected results:
filter should not be saveable with empty field

Additional info:
Fatal Error in production.log
Comment 2 Ryan Spagnola 2019-08-14 14:59:07 UTC 
Created attachment 1603788 [details]
production.log
Comment 4 Yuri Rudman 2019-08-19 13:54:23 UTC 
*** Bug 1743188 has been marked as a duplicate of this bug. ***
Comment 5 Yuri Rudman 2019-08-19 14:00:03 UTC 
there was duplicated BZ with different steps to duplicate:

1. Go to Services > My Services
2. Open Advanced Search and create some expression, commit it
3. Save the filter: click on Save, then name the filter,
   click on Save button again (and don't close Advanced search)
4. Click on Apply button
Comment 6 CFME Bot 2019-08-20 19:40:46 UTC 
https://github.com/ManageIQ/manageiq/pull/19176
Comment 7 CFME Bot 2019-08-22 19:37:18 UTC 
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/3ad5e19c82439c52cef779b3cdf901a6e3b2bcfc
commit 3ad5e19c82439c52cef779b3cdf901a6e3b2bcfc
Author:     Yuri Rudman <yrudman>
AuthorDate: Tue Aug 20 14:47:10 2019 -0400
Commit:     Yuri Rudman <yrudman>
CommitDate: Tue Aug 20 14:47:10 2019 -0400

    during sql generation unexpected error was raised if SQL generation for expression is not supportyed and extra entry (:token) was present in MiqExpression's Hash.
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741243

 lib/miq_expression.rb | 2 +-
 spec/lib/miq_expression_spec.rb | 15 +
 2 files changed, 16 insertions(+), 1 deletion(-)
Comment 8 Ievgen Zapolskyi 2019-10-09 06:48:22 UTC 
I have the same error and back trace when save/load search expression in Instances view in 5.11.0.27.
screenshot attached.



[----] I, [2019-10-09T02:38:21.115097 #23351:2b23d4da712c]  INFO -- : Started POST "/vm_cloud/report_data" for 10.36.116.185 at 2019-10-09 02:38:21 -0400
[----] I, [2019-10-09T02:38:21.123153 #23351:2b23d4da712c]  INFO -- : Processing by VmCloudController#report_data as HTML
[----] I, [2019-10-09T02:38:21.123441 #23351:2b23d4da712c]  INFO -- :   Parameters: {"model_name"=>"ManageIQ::Providers::CloudManager::Vm", "model"=>"ManageIQ::Providers::CloudManager::Vm", "active_tree"=>"instances_filter_tree", "explorer"=>true, "additional_options"=>{"named_scope"=>[], "gtl_dbname"=>nil, "model"=>"ManageIQ::Providers::CloudManager::Vm", "match_via_descendants"=>nil, "parent_id"=>nil, "parent_class_name"=>nil, "parent_method"=>nil, "association"=>nil, "view_suffix"=>nil, "row_button"=>nil, "menu_click"=>nil, "sb_controller"=>nil, "embedded"=>nil, "showlinks"=>nil, "policy_sim"=>nil, "in_a_form"=>nil, "lastaction"=>"show_list", "display"=>nil, "gtl_type"=>"grid", "supported_features_filter"=>nil, "clickable"=>nil, "no_checkboxes"=>nil, "report_name"=>nil, "custom_action"=>nil}, "vm"=>{}}
[----] F, [2019-10-09T02:38:21.158596 #23351:2b23d4da712c] FATAL -- : Error caught: [RuntimeError] operator 'token' is not supported
/var/www/miq/vmdb/lib/miq_expression.rb:1437:in `to_arel'
/var/www/miq/vmdb/lib/miq_expression.rb:289:in `to_sql'
/var/www/miq/vmdb/lib/rbac/filterer.rb:257:in `search'
/var/www/miq/vmdb/lib/rbac/filterer.rb:146:in `search'
/var/www/miq/vmdb/lib/rbac.rb:3:in `search'
/var/www/miq/vmdb/app/models/miq_report/search.rb:117:in `paged_view_search'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-3a49768831a8/app/controllers/application_controller.rb:1325:in `get_view'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-3a49768831a8/app/controllers/application_controller.rb:422:in `report_data'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/abstract_controller/base.rb:186:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/rendering.rb:30:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/callbacks.rb:131:in `run_callbacks'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/abstract_controller/callbacks.rb:19:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/rescue.rb:20:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications.rb:166:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications.rb:166:in `instrument'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/params_wrapper.rb:252:in `process_action'
/opt/rh/cfme-gemset/gems/activerecord-5.1.7/lib/active_record/railties/controller_runtime.rb:22:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/abstract_controller/base.rb:124:in `process'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/rendering.rb:30:in `process'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal.rb:189:in `dispatch'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal.rb:253:in `dispatch'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/routing/route_set.rb:49:in `dispatch'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/routing/route_set.rb:31:in `serve'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/journey/router.rb:50:in `block in serve'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/journey/router.rb:33:in `each'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/journey/router.rb:33:in `serve'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/routing/route_set.rb:844:in `call'
/opt/rh/cfme-gemset/bundler/gems/cfme-graphql-ef6880aaae05/lib/manageiq/graphql/rest_api_proxy.rb:18:in `call'
/opt/rh/cfme-gemset/gems/secure_headers-3.0.3/lib/secure_headers/middleware.rb:10:in `call'
/var/www/miq/vmdb/lib/request_started_on_middleware.rb:12:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/etag.rb:25:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/conditional_get.rb:38:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/head.rb:12:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/session/abstract/id.rb:232:in `context'
/opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/session/abstract/id.rb:226:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/cookies.rb:613:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/callbacks.rb:26:in `block in call'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/callbacks.rb:97:in `run_callbacks'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/callbacks.rb:24:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/debug_exceptions.rb:59:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
/opt/rh/cfme-gemset/gems/railties-5.1.7/lib/rails/rack/logger.rb:36:in `call_app'
/opt/rh/cfme-gemset/gems/railties-5.1.7/lib/rails/rack/logger.rb:26:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/remote_ip.rb:79:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/request_id.rb:25:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/method_override.rb:22:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/runtime.rb:22:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/cache/strategy/local_cache_middleware.rb:27:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/executor.rb:12:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/sendfile.rb:111:in `call'
/opt/rh/cfme-gemset/gems/railties-5.1.7/lib/rails/engine.rb:522:in `call'
/usr/share/gems/gems/puma-3.7.1/lib/puma/configuration.rb:232:in `call'
/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:578:in `handle_request'
/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:415:in `process_client'
/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:275:in `block in run'
/usr/share/gems/gems/puma-3.7.1/lib/puma/thread_pool.rb:120:in `block in spawn_thread'
[----] I, [2019-10-09T02:38:21.164625 #23351:2b23d4da712c]  INFO -- :   Rendering /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-3a49768831a8/app/views/layouts/exception.html.haml within layouts/application
[----] I, [2019-10-09T02:38:21.186901 #23351:2b23d4da712c]  INFO -- :   Rendered /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-3a49768831a8/app/views/layouts/_exception_contents.html.haml (14.8ms)
[----] I, [2019-10-09T02:38:21.187132 #23351:2b23d4da712c]  INFO -- :   Rendered /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-3a49768831a8/app/views/layouts/exception.html.haml within layouts/application (22
Comment 9 Ievgen Zapolskyi 2019-10-09 06:49:00 UTC 
Created attachment 1623728 [details]
screenshot