Bug 1741427

Summary: Restore rsync error code 23 as an important warning
Product: [Fedora] Fedora EPEL Reporter: g.danti
Component: rsnapshotAssignee: Robert Scheck <redhat-bugzilla>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: epel7CC: james.hogarth, redhat-bugzilla, strobert
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: rsnapshot-1.4.3-1.el7 rsnapshot-1.4.3-1.el6_10 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-05 00:07:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description g.danti 2019-08-15 05:32:15 UTC 
Description of problem:
The latest rsnapshot release treats rsync exit codes 23 and 24 a simple warning, with *no* output unless "verbose" > 3. While exit code 24 (file vanished) can be considered as a simple warning, exit code 23 (I/O error) should *not* be considered as such; rather, it should be very clearly indicated in the output at verbose level 2 or 3.

Please see PR#179 (https://github.com/rsnapshot/rsnapshot/pull/179) for more details.

Version-Release number of selected component (if applicable):
1.4.2

How reproducible:
Create a rsnapshot configuration backing up a non-existant directory, run rsnapshot and see how it fails (with exit code 2) with *no* warning on the command line.

Steps to Reproduce:
1. create a rsnapshot configuration backing up a non-existant directory;
2. run rsnashot;
3. the backup fails with nothing printed on the command line.

Actual results:
No error/warning shown.

Expected results:
IO Error should generate a very clear warning/error/report on the command line.

Additional info:
See PR179: https://github.com/rsnapshot/rsnapshot/pull/179
Comment 1 Fedora Update System 2019-12-12 20:35:24 UTC 
FEDORA-EPEL-2019-6f33b901f5 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-6f33b901f5
Comment 2 Fedora Update System 2019-12-12 20:37:54 UTC 
FEDORA-EPEL-2019-50a64de266 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-50a64de266
Comment 3 Fedora Update System 2019-12-13 02:01:51 UTC 
rsnapshot-1.4.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-6f33b901f5
Comment 4 Fedora Update System 2019-12-13 03:04:59 UTC 
rsnapshot-1.4.3-1.el6_10 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-50a64de266
Comment 5 Fedora Update System 2020-01-05 00:07:32 UTC 
rsnapshot-1.4.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
Comment 6 Fedora Update System 2020-01-07 00:26:26 UTC 
rsnapshot-1.4.3-1.el6_10 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.