Bug 1741472
| Summary: | Fix stack overflow in: `inotifytools_replace_filename` | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Kratochvil <jan.kratochvil> | ||||
| Component: | inotify-tools | Assignee: | Adel Gadllah <adel.gadllah> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 30 | CC: | adel.gadllah, jan.kratochvil, mhroncok, mmckinst | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | aarch64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | inotify-tools-3.14-17.fc30 inotify-tools-3.14-16.fc29 inotify-tools-3.14-2.el6 inotify-tools-3.14-9.el7 inotify-tools-3.14-18.fc31 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2019-09-14 01:12:16 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Jan Kratochvil
2019-08-15 09:13:46 UTC
A ping as it looks to me easy to fix by any of the two available patches. Thanks for submitting this but I'm going to decline put custom patch in Fedora. The upstream project appears to be inactive and I don't have the skills to maintain custom patches or a fork. I'm not a C programmer so I can't verify this patch works or have any insight if its good/bad. https://fedoraproject.org/wiki/Staying_close_to_upstream_projects#Some_Examples_Of_Exceptions has some more info on how we handle inactive upstream projects. Created attachment 1608380 [details] Debian fix (In reply to Mark McKinstry from comment #2) > The upstream project appears to be inactive and I don't have the skills to > maintain custom patches or a fork. OK, so offering a patch from Debian which cannot have any regression as it just increases size of an array from 2 to 3 (or from 3 to 4, depending on arch). > https://fedoraproject.org/wiki/ > Staying_close_to_upstream_projects#Some_Examples_Of_Exceptions has some more > info on how we handle inactive upstream projects. This is "major bug fix" - it does crash after left running monitoring for longer time (=over night). "Unmaintained Or Unresponsive Upstream Projects" - "it might be acceptable to patch the software" + "sharing patches with other distributions" (see above) "taking over maintenance if you have the time, skills, and interest" - not really, I do other stuff (LLDB) and I do not want to get close to kernel. Mark, if upstream is dead and you refuse to take patches because you "don't have the skills to maintain custom patches or a fork", is there nay way out. Should you orphan the package or find co-maintainers? Jan, would you be able to help? I can become a co-maintainer (if there is no one more close to kernel development) as the work on this package seems to be very little and it has even no other open Bugs. At https://pagure.io/releng/issue/8727 @churchyard says to become a co-maintainer: # @drago01 or @mmckinst can add you Jan, I didn't realize you were a package maintainer in Fedora. I've added you as an admin at https://src.fedoraproject.org/rpms/inotify-tools/settings#usersgroups-tab which I think should give you access. Let me know if that doesn't give you the access you need to patch and rebuild. FEDORA-EPEL-2019-665999d740 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-665999d740 FEDORA-EPEL-2019-6923112e79 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-6923112e79 FEDORA-2019-845325db09 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-845325db09 inotify-tools-3.14-18.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a009221643 inotify-tools-3.14-17.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-845325db09 inotify-tools-3.14-16.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d1a9722069 inotify-tools-3.14-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-665999d740 inotify-tools-3.14-9.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-6923112e79 inotify-tools-3.14-17.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. inotify-tools-3.14-16.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. inotify-tools-3.14-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. inotify-tools-3.14-9.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. inotify-tools-3.14-18.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. |