Bug 1743267

Summary:	Review Request: perl-Test2-Plugin-MemUsage - Test2 plugin that collects and displays memory usage information
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test2-Plugin-MemUsage-0.2.2-1.fc32	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-21 07:40:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1742763

Description Petr Pisar 2019-08-19 13:50:08 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Test2-Plugin-MemUsage/perl-Test2-Plugin-MemUsage.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test2-Plugin-MemUsage/perl-Test2-Plugin-MemUsage-0.2.1-1.fc32.src.rpm
Description:
This Test2 plugin will collect memory usage information from /proc/PID/status
and display it for you when the test is done running.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-08-20 09:03:44 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test2-Plugin-MemUsage-0.2.1-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(strict)
      1 perl(Test2::API) >= 1.302165
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Test2-Plugin-MemUsage-0.2.1-1.fc32.noarch.rpm | sort | uniq -c
      1 perl(Test2::Plugin::MemUsage) = 0.002001
      1 perl-Test2-Plugin-MemUsage = 0.2.1-1.fc32
Binary provides are Ok.

$ rpmlint ./perl-Test2-Plugin-MemUsage*
perl-Test2-Plugin-MemUsage.noarch: W: spelling-error %description -l en_US proc -> crop, prov, pro
perl-Test2-Plugin-MemUsage.src: W: spelling-error %description -l en_US proc -> crop, prov, pro
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

FIX: The latest version is 0.002002, please update it before submit.

Please correct 'FIX' issue.

Resolution:
Approved

Comment 2 Gwyn Ciesla 2019-08-20 15:17:00 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test2-Plugin-MemUsage

Comment 3 Petr Pisar 2019-08-21 07:40:26 UTC

Thank you for the review and the repository. I upgraded the package.