Bug 174328
| Summary: | Review Request: tklib - a set of useful packages for Tk | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wart <wart> | ||||
| Component: | Package Review | Assignee: | Dmitry Butskoy <dmitry> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-extras-list | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://tcllib.sourceforge.net | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-12-05 06:28:03 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Wart
2005-11-28 00:56:52 UTC
This package provides "make check" possibility, therefore it must be done (in the special %check section of the spec file). For me (under FC3) "make check" fails. Probably it is caused by absence of the files in the normal install path (the files are present under $RPM_BUILD_ROOT at the check time). Probably something another reason... Anyway, try to provide "make check" success at rpmbuild time. The "make check" failure is caused by a bug in the script that actually performs the check. Here is a new package that fixes the bug and adds the %check section to the spec file. http://www.kobold.org/~wart/fedora/tklib-0.4.1-2.src.rpm Patch has been submitted upstream. I'm not sure if this provides anything useful, though. I took a closer look at the script that performs the check, and it will always exit with code '0' unless there is an error in the script itself or if it was invoked with invalid arguments. If any of the checks fail, it will still return with exit code '0'. Remarks & nitpicks:
- spec file should not have execution bit set ("chmod -x tklib.spec")
- patch filename should have the upstream version included (for the moment the
patch is appeared), i.e. tklib-0.4.1-makecheck.patch
- remove leading "A" from the Summary field.
- add "rm -rf $RPM_BUILD_ROOT" into the beginning of %install section.
- IMHO it is a little more robust to use wildcards in the %files section.
Created attachment 121739 [details]
Suggested changes for the spec file
I won't argue with any of the suggestions, but I do agree that they are nitpicks. :) Here's the next attempt: http://www.kobold.org/~wart/fedora/tklib-0.4.1-3.src.rpm http://www.kobold.org/~wart/fedora/tklib.spec Built OK MUST/SHOULD items OK APPROVED. |