Bug 1743288

Summary: Review Request: perl-Test2-Plugin-UUID - Use real UUIDs in Test2
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Test2-Plugin-UUID-0.2.1-1.fc32 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-21 08:04:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1742814    
Bug Blocks: 1742763    

Description Petr Pisar 2019-08-19 14:33:23 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Test2-Plugin-UUID/perl-Test2-Plugin-UUID.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test2-Plugin-UUID/perl-Test2-Plugin-UUID-0.2.1-1.fc32.src.rpm
Description:
Test2 normally uses unique IDs generated by appending PID, thread ID, and an
incrementing integer. These work fine most of the time, but are not sufficient
if you want to keep a database of events, in that case a real UUID is much
more useful.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2019-08-20 11:30:50 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test2-Plugin-UUID-0.2.1-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Data::UUID) >= 1.148
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(strict)
      1 perl(Test2::API) >= 1.302165
      1 perl(Test2::Hub)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Test2-Plugin-UUID-0.2.1-1.fc32.noarch.rpm | sort | uniq -c
      1 perl(Test2::Plugin::UUID) = 0.002001
      1 perl-Test2-Plugin-UUID = 0.2.1-1.fc32
Binary provides are Ok.

$ rpmlint ./perl-Test2-Plugin-UUID*
perl-Test2-Plugin-UUID.noarch: W: spelling-error %description -l en_US incrementing -> increment, infringement, tormenting
perl-Test2-Plugin-UUID.src: W: spelling-error %description -l en_US incrementing -> increment, infringement, tormenting
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.

Resolution:
Approved
Comment 2 Gwyn Ciesla 2019-08-20 15:35:51 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test2-Plugin-UUID
Comment 3 Petr Pisar 2019-08-21 08:04:11 UTC 
Thank you for the review and the repository.