Bug 1743529
| Summary: | reconfigure dialog cannot be open for stopped rhev vms | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Ievgen Zapolskyi <izapolsk> | ||||
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||
| Status: | CLOSED EOL | QA Contact: | Niyaz Akhtar Ansari <nansari> | ||||
| Severity: | high | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> | ||||
| Priority: | medium | ||||||
| Version: | 5.11.0 | CC: | akarol, bmidwood, hkataria, lavenel, mpovolny, nansari, obarenbo, smallamp | ||||
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||
| Target Release: | 5.12.0 | Flags: | mfeifer:
mirror+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1784182 (view as bug list) | Environment: | |||||
| Last Closed: | 2020-03-25 18:03:16 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | Bug | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | RHEVM | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1784182 | ||||||
| Attachments: |
|
||||||
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/ad9a2df375eb2d410c41350fd70baeb5dcb9fd80 commit ad9a2df375eb2d410c41350fd70baeb5dcb9fd80 Author: Harpreet Kataria <hkataria> AuthorDate: Tue Aug 20 17:22:34 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Aug 20 17:22:34 2019 -0400 Fix nilClass error Added nil check to fix `undefined method `storages' for nil:NilClass` error Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1743529 app/controllers/mixins/actions/vm_actions/reconfigure.rb | 1 + spec/controllers/mixins/actions/vm_actions/reconfigure_spec.rb | 6 + 2 files changed, 7 insertions(+) *** Bug 1744993 has been marked as a duplicate of this bug. *** |
Created attachment 1606008 [details] logs Description of problem: When I try to open reconfigure dialog for stopped rhv vm, it doesn't show up. there's also an exception in logs. Version-Release number of selected component (if applicable): 5.11.0.19 How reproducible: 100% Steps to Reproduce: 1. add rhv43 provider to appliance 2. find any stopped rhv vm in appliance or stop running one 3. choose Configuration->Reconfigure this VM Actual results: nothing happens. exception in logs Expected results: no such issue Additional info: [----] I, [2019-08-20T03:38:30.803104 #3031:2ac4721e0cd8] INFO -- : Started POST "/vm_infra/x_button/11000000000714?pressed=vm_reconfigure" for 10.36.116.21 at 2019-08-20 03:38:30 -0400 [----] I, [2019-08-20T03:38:30.806326 #3031:2ac4721e0cd8] INFO -- : Processing by VmInfraController#x_button as JS [----] I, [2019-08-20T03:38:30.806378 #3031:2ac4721e0cd8] INFO -- : Parameters: {"pressed"=>"vm_reconfigure", "id"=>"11000000000714"} [----] F, [2019-08-20T03:38:30.827771 #3031:2ac4721e0cd8] FATAL -- : Error caught: [NoMethodError] undefined method `storages' for nil:NilClass /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-3cad7fea564b/app/controllers/mixins/actions/vm_actions/reconfigure.rb:236:in `get_iso_options' /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-3cad7fea564b/app/controllers/mixins/actions/vm_actions/reconfigure.rb:24:in `reconfigure' /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-3cad7fea564b/app/controllers/mixins/actions/vm_actions/reconfigure.rb:78:in `reconfigurevms' /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-3cad7fea564b/app/controllers/application_controller/explorer.rb:132:in `x_button' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/abstract_controller/base.rb:186:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/rendering.rb:30:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/abstract_controller/callbacks.rb:20:in `block in process_action' /opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/callbacks.rb:131:in `run_callbacks' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/abstract_controller/callbacks.rb:19:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/rescue.rb:20:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action' /opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications.rb:166:in `block in instrument' /opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications/instrumenter.rb:21:in `instrument' /opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications.rb:166:in `instrument' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/instrumentation.rb:30:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/params_wrapper.rb:252:in `process_action' /opt/rh/cfme-gemset/gems/activerecord-5.1.7/lib/active_record/railties/controller_runtime.rb:22:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/abstract_controller/base.rb:124:in `process' /opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/rendering.rb:30:in `process' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal.rb:189:in `dispatch' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal.rb:253:in `dispatch' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/routing/route_set.rb:49:in `dispatch' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/routing/route_set.rb:31:in `serve' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/journey/router.rb:50:in `block in serve' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/journey/router.rb:33:in `each' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/journey/router.rb:33:in `serve' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/routing/route_set.rb:844:in `call' /opt/rh/cfme-gemset/bundler/gems/cfme-graphql-ef6880aaae05/lib/manageiq/graphql/rest_api_proxy.rb:18:in `call' /opt/rh/cfme-gemset/gems/secure_headers-3.0.3/lib/secure_headers/middleware.rb:10:in `call' /var/www/miq/vmdb/lib/request_started_on_middleware.rb:12:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/etag.rb:25:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/conditional_get.rb:38:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/head.rb:12:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/session/abstract/id.rb:232:in `context' /opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/session/abstract/id.rb:226:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/cookies.rb:613:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/callbacks.rb:26:in `block in call' /opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/callbacks.rb:97:in `run_callbacks' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/callbacks.rb:24:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/debug_exceptions.rb:59:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call' /opt/rh/cfme-gemset/gems/railties-5.1.7/lib/rails/rack/logger.rb:36:in `call_app' /opt/rh/cfme-gemset/gems/railties-5.1.7/lib/rails/rack/logger.rb:26:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/remote_ip.rb:79:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/request_id.rb:25:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/method_override.rb:22:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/runtime.rb:22:in `call' /opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/cache/strategy/local_cache_middleware.rb:27:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_dispatch/middleware/executor.rb:12:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.7/lib/rack/sendfile.rb:111:in `call' /opt/rh/cfme-gemset/gems/railties-5.1.7/lib/rails/engine.rb:522:in `call' /usr/share/gems/gems/puma-3.7.1/lib/puma/configuration.rb:232:in `call' /usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:578:in `handle_request' /usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:415:in `process_client' /usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:275:in `block in run' /usr/share/gems/gems/puma-3.7.1/lib/puma/thread_pool.rb:120:in `block in spawn_thread' [----] I, [2019-08-20T03:38:30.828603 #3031:2ac4721e0cd8] INFO -- : Rendered /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-3cad7fea564b/app/views/layouts/_exception_contents.html.haml (0.1ms) [----] I, [2019-08-20T03:38:30.829008 #3031:2ac4721e0cd8] INFO -- : Completed 200 OK in 23ms (Views: 1.0ms | ActiveRecord: 5.1ms)