Bug 1743776
Summary: | Error while deleting the content view version. | |||
---|---|---|---|---|
Product: | Red Hat Satellite | Reporter: | Ganesh Payelkar <gpayelka> | |
Component: | Pulp | Assignee: | satellite6-bugs <satellite6-bugs> | |
Status: | CLOSED ERRATA | QA Contact: | Lai <ltran> | |
Severity: | urgent | Docs Contact: | ||
Priority: | urgent | |||
Version: | 6.5.0 | CC: | ahumbe, bmbouter, dgross, dkliban, ehelms, ggainey, ipanova, ltran, mawerner, mmccune, mschibli, pcreech, rchan, satellite6-bugs, smajumda, ttereshc, val.baranov, vwariyal | |
Target Milestone: | 6.8.0 | Keywords: | Triaged | |
Target Release: | Unused | |||
Hardware: | x86_64 | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | pulp-rpm-2.21.3-1 | Doc Type: | Known Issue | |
Doc Text: |
Error while deleting the content view version
|
Story Points: | --- | |
Clone Of: | ||||
: | 1851136 (view as bug list) | Environment: | ||
Last Closed: | 2020-10-27 12:59:02 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: |
Description
Ganesh Payelkar
2019-08-20 16:14:17 UTC
Changing bug from affected version 6.4.2 to 6.5.0. (It was really encountered on 6.5.2, but that's not a valid dropdown selection yet) The exception raised as part of aggregated set of errors, so it would be helpful to see pulp logs because all details are there, unfortunately. And they should point to a spot where it happens. > From the code comments, I can see that it is trying to re-delete the distributor and content but it is obvious that if it is trying to re-delete it will not find the file >"/var/lib/pulp/published/yum/https/repos/redhat/content_views/RHEL_7/78.0/content/dist/rhel/server/7/7Server/x86_64/sat-tools/listing". I don't think it's an issue, the attempt there is to clean database and not the filesystem. I can't reproduce the issue and the only potential spot I found is here. https://github.com/pulp/pulp_rpm/compare/2-master...goosemania:issue2826.patch If anyone can try the patch and/or reproduce and share the logs, it would be helpful. The Pulp upstream bug status is at NEW. Updating the external tracker on this bug. The Pulp upstream bug priority is at Normal. Updating the external tracker on this bug. Hi Dylan, Thanks for this! I'm glad there is a place to reproduce the issue and test the patch. I was looking for it. Sorry to hear that the customer needed to dig into the code. With my blind search, I found the second spot with my initial patch from comment#7 but not the first one. Thanks for figuring it out. The suggested patch by the customer has some issues. Depending on the reasons for the file or directory removal to fail, code should react differently. We can safely ignore only the case when they no longer exist, any other OSError is not safe to ignore and it would be better if failure is not ignored but propagated, e.g. permission problem. `If` statements are not safe to use due to race condition nature of the problem, so I added try/except for the first spot you found as well. Here is the suggested patch to test https://patch-diff.githubusercontent.com/raw/pulp/pulp_rpm/pull/1748.patch If it works, we will include it in the upcoming release. The Pulp upstream bug status is at POST. Updating the external tracker on this bug. The Pulp upstream bug status is at MODIFIED. Updating the external tracker on this bug. All upstream Pulp bugs are at MODIFIED+. Moving this bug to POST. The Pulp upstream bug status is at CLOSED - CURRENTRELEASE. Updating the external tracker on this bug. Requesting needsinfo from upstream developer ttereshc because the 'FailedQA' flag is set. This should be fixed in pulp-rpm-plugins-2.21.3-1 Steps to reproduce. 1. Enabling a bunch of red hat repos (mine was around 10) 1a (optional) - sync repos 2. Create a cv and add all the repos from 1 to it 3. Publish repo 2 - 3 times 4. Delete one cv version 5. Check task page 6. Check distributor.py for patch Expected: 5. Task should return no error 6. The code should be the same as mentioned in comment #14 Actual: 5. Task returns no errors for deleting cv version 6. The code is the same as mentioned in comment #14 Also checked the pulp version: pulp-rpm-plugins-2.21.3-2.el7sat.noarch Verified on 6.8.0 snap 15 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: Satellite 6.8 release), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:4366 |