Bug 1743802 (taskopen)

Summary:	Review Request: taskopen - Script for taking notes and open urls with taskwarrior
Product:	[Fedora] Fedora	Reporter:	Ankur Sinha (FranciscoD) <sanjay.ankur>
Component:	Package Review	Assignee:	Igor Raits <igor.raits>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	igor.raits, package-review
Target Milestone:	---	Flags:	igor.raits: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	Trivial, Easyfix
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-29 22:06:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ankur Sinha (FranciscoD) 2019-08-20 17:42:39 UTC

Spec URL: https://ankursinha.fedorapeople.org/taskopen/taskopen.spec
SRPM URL: https://ankursinha.fedorapeople.org/taskopen/taskopen-1.1.4-1.fc30.src.rpm

Description:
taskopen allows you to link almost any file, webpage or command to a
taskwarrior task by adding a filepath, web-link or uri as an annotation. Text
notes, images, PDF files, web addresses, spreadsheets and many other types of
links can then be filtered, listed and opened by using taskopen. Some actions
are sane defaults, others can be custom-configured, and everything else will
use your systems mime-types to open the link.

Arbitrary commands can be used with taskopen at the CLI, acting on the link
targets, enhancing listings and even executing annotations as commands.

Run 'taskopen -h' or 'man taskopen' for further details. The following sections
show some (very) basic usage examples.


Fedora Account System Username: ankursinha

Comment 1 Igor Raits 2019-08-20 17:47:28 UTC

> BuildRequires:  perl

BuildRequires: perl-generators

> Requires:       perl(JSON)

Not needed after change above.

> rm -rf $RPM_BUILD_ROOT

Not needed.

> %{_mandir}/man1/taskopen.1.gz
> %{_mandir}/man5/taskopenrc.5.gz

%{_mandir}/man1/taskopen.1*
%{_mandir}/man5/taskopenrc.5*

> %{_datadir}/%{name}

%{_datadir}/%{name}/

---

Everything else looks good.

Comment 2 Ankur Sinha (FranciscoD) 2019-08-20 18:01:27 UTC

Thanks Igor, updated spec/srpm:


Spec URL: https://ankursinha.fedorapeople.org/taskopen/taskopen.spec
SRPM URL: https://ankursinha.fedorapeople.org/taskopen/taskopen-1.1.4-1.fc30.src.rpm


diff --git a/taskopen.spec b/taskopen.spec
index cf08592..f186740 100644
--- a/taskopen.spec
+++ b/taskopen.spec
@@ -6,12 +6,11 @@ Summary:        Script for taking notes and open urls with taskwarrior
 License:        GPLv2+
 URL:            https://github.com/ValiValpas/taskopen
 Source0:        https://github.com/ValiValpas/taskopen/archive/v%{version}/%{name}-%{version}.tar.gz
+BuildArch:      noarch
 
-BuildRequires:  perl
-Requires:       task
-Requires:       perl(JSON)
+BuildRequires: perl-generators
 
-BuildArch:      noarch
+Requires:       task
 
 %description
 taskopen allows you to link almost any file, webpage or command to a
@@ -39,7 +38,6 @@ rm -vf doc/html/*.orig
 
 
 %install
-rm -rf $RPM_BUILD_ROOT
 %make_install PREFIX=%{_prefix}
 
 # Wrong location, we'll intall it ourselves
@@ -49,10 +47,11 @@ rm -rfv $RPM_BUILD_ROOT/%{_datadir}/taskopen/doc
 %files
 %doc examples doc/html/
 %{_bindir}/%{name}
-%{_mandir}/man1/taskopen.1.gz
-%{_mandir}/man5/taskopenrc.5.gz
-%{_datadir}/%{name}
+%{_mandir}/man1/taskopen.1.*
+%{_mandir}/man5/taskopenrc.5.*
+%{_datadir}/%{name}/
 
 %changelog
 * Tue Aug 20 2019 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 1.1.4-1
 - Initial build
+- Update as per review comments: https://bugzilla.redhat.com/show_bug.cgi?id=1743802

Comment 3 Igor Raits 2019-08-21 05:03:06 UTC

> +%{_mandir}/man1/taskopen.1.*
> +%{_mandir}/man5/taskopenrc.5.*

It should be '*', not '.*'.

But this is minor. Fix it during the import please.

Comment 4 Ankur Sinha (FranciscoD) 2019-08-21 08:01:54 UTC

Thanks!

Updated: https://ankursinha.fedorapeople.org/taskopen/taskopen.spec

Requesting SCM now.

Comment 5 Gwyn Ciesla 2019-08-21 13:37:36 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/taskopen

Comment 6 Fedora Update System 2019-08-21 15:54:30 UTC

FEDORA-2019-37143761ce has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-37143761ce

Comment 7 Fedora Update System 2019-08-21 15:54:31 UTC

FEDORA-2019-887fdbbe8e has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-887fdbbe8e

Comment 8 Fedora Update System 2019-08-22 03:32:37 UTC

taskopen-1.1.4-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-37143761ce

Comment 9 Fedora Update System 2019-08-22 03:40:20 UTC

taskopen-1.1.4-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-887fdbbe8e

Comment 10 Fedora Update System 2019-08-29 22:06:21 UTC

taskopen-1.1.4-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2019-08-30 00:50:42 UTC

taskopen-1.1.4-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.