Bug 1743896

The f32-python side tag has been merged. In order to rebuild the package, do it in regular rawhide, but please wait until python3-3.8 is tagged:

  $ koji wait-repo f32-build --build python3-3.8.0~b3-3.fc32


If your built already started in f32-python, after it is finished, please tag it to rawhide with:

  $ koji tag-build f32-pending <nvr>

For example:

  $ koji tag-build f32-pending libreoffice-6.3.0.4-3.fc32

Thanks!

(This comment is mass posted to all bugzillas blocking the PYTHON38 tracking bug.)

(Python 3.8 has landed in the rawhide buildroot.)

make[3]: Entering directory '/builddir/build/BUILD/ParaView-v5.6.0/x86_64-redhat-linux-gnu'
BUILDSTDERR: cd /builddir/build/BUILD/ParaView-v5.6.0/x86_64-redhat-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /builddir/build/BUILD/ParaView-v5.6.0 /builddir/build/BUILD/ParaView-v5.6.0/CommandLineExecutables /builddir/build/BUILD/ParaView-v5.6.0/x86_64-redhat-linux-gnu /builddir/build/BUILD/ParaView-v5.6.0/x86_64-redhat-linux-gnu/CommandLineExecutables /builddir/bFatal Python error: no mem for sys.argv
BUILDSTDERR: SystemError: /builddir/build/BUILD/Python-3.8.0b3/Objects/unicodeobject.c:2089: bad argument to internal function
BUILDSTDERR: Current thread 0x00007f6f456c7900 (most recent call first):
BUILDSTDERR: make[3]: *** [Utilities/Sphinx/CMakeFiles/ParaViewPythonDoc.dir/build.make:60: Utilities/Sphinx/CMakeFiles/ParaViewPythonDoc] Aborted (core dumped)
BUILDSTDERR: make[2]: *** [CMakeFiles/Makefile2:52830: Utilities/Sphinx/CMakeFiles/ParaViewPythonDoc.dir/all] Error 2
BUILDSTDERR: make[1]: *** [CMakeFiles/Makefile2:162: CMakeFiles/ParaViewDoc.dir/rule] Error 2
BUILDSTDERR: make: *** [Makefile:215: ParaViewDoc] Error 2
BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.uW7bXl (%build)
uild/BUILD/ParaView-v5.6.0/x86_64-redhat-linux-gnu/CommandLineExecutables/CMakeFiles/pvpython.dir/DependInfo.cmake --color=

unfortunately the stderr and stdout is mixed, but it seems like we're hitting some kind of python memory issue.

Hmm... there are several dangerous lines:


error: no mem for sys.argv

BUILDSTDERR: SystemError: /builddir/build/BUILD/Python-3.8.0b3/Objects/unicodeobject.c:2089: bad argument to internal function

Aborted (core dumped)

Python-3.8.0b3/Objects/unicodeobject.c:2089:

PyObject *
PyUnicode_FromWideChar(const wchar_t *u, Py_ssize_t size)
{
    PyObject *unicode;
    Py_UCS4 maxchar = 0;
    Py_ssize_t num_surrogates;

    if (u == NULL && size != 0) {
        PyErr_BadInternalCall();               <-------- 2089
        return NULL;
    }



ParaView-v5.6.0/VTK/Utilities/PythonInterpreter/vtkPythonInterpreter.cxx has:

    // setup default argv. Without this, code snippets that check `sys.argv` may
    // fail when run in embedded VTK Python environment.
    PySys_SetArgvEx(0, nullptr, 0);


I wonder whether PySys_SetArgvEx isn't broken for 0.

#define PY_SSIZE_T_CLEAN
#include <Python.h>

int
main(int argc, char *argv[])
{
    wchar_t *program = Py_DecodeLocale(argv[0], NULL);
    if (program == NULL) {
        fprintf(stderr, "Fatal error: cannot decode argv[0]\n");
        exit(1);
    }
    Py_SetProgramName(program);  /* optional but recommended */
    Py_Initialize();
    PySys_SetArgvEx(0, NULL, 0);
    PyRun_SimpleString("from time import time,ctime\n"
                       "print('Today is', ctime(time()))\n");
    if (Py_FinalizeEx() < 0) {
        exit(120);
    }
    PyMem_RawFree(program);
    return 0;
}


$ gcc $(python3.7-config --cflags --ldflags) example.c 
$ ./a.out 
Today is Fri Aug 23 07:54:17 2019
$ gcc $(python3.8-config --cflags --ldflags --embed) example.c 
$ ./a.out 
Fatal Python error: no mem for sys.argv
SystemError: /builddir/build/BUILD/Python-3.8.0b3/Objects/unicodeobject.c:2089: bad argument to internal function

Current thread 0x00007f05f6328740 (most recent call first):
Aborted (core dumped)

Will report this as a regression.

A Python fix is at https://github.com/python/cpython/pull/15415

I suggest we don't backport it but instead wait for the next beta scheduled for Monday (2019-08-26), assuming the fix will be included there.