Bug 1743899

Summary:	python-oslo-utils fails to build with Python 3.8
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	python-oslo-utils	Assignee:	Alfredo Moralejo <amoralej>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	amoralej, apevec, gchamoul
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-oslo-utils-3.40.3-4.fc32	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-22 15:48:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1686977

Description Miro Hrončok 2019-08-20 23:21:23 UTC

python-oslo-utils-3.40.3-3.fc32 failed to rebuild with Python 3.8.

See https://koji.fedoraproject.org/koji/buildinfo?buildID=1359867

The error is:

BUILDSTDERR: ======================================================================
BUILDSTDERR: ERROR: test_constant_time_compare (oslo_utils.tests.test_secretutils.SecretUtilsTest)
BUILDSTDERR: oslo_utils.tests.test_secretutils.SecretUtilsTest.test_constant_time_compare (binary)
BUILDSTDERR: ----------------------------------------------------------------------
BUILDSTDERR: testtools.testresult.real._StringException: Traceback (most recent call last):
BUILDSTDERR:   File "/builddir/build/BUILD/oslo.utils-3.40.3/oslo_utils/tests/test_secretutils.py", line 40, in test_constant_time_compare
BUILDSTDERR:     self.assertTrue(ctc(self.converter(u'abcd'),
BUILDSTDERR:   File "/builddir/build/BUILD/oslo.utils-3.40.3/oslo_utils/tests/test_secretutils.py", line 26, in <lambda>
BUILDSTDERR:     _gen_digest = lambda text: hmac.new(b'foo', text.encode('utf-8')).digest()
BUILDSTDERR:   File "/usr/lib/python3.8/hmac.py", line 146, in new
BUILDSTDERR:     return HMAC(key, msg, digestmod)
BUILDSTDERR:   File "/usr/lib/python3.8/hmac.py", line 49, in __init__
BUILDSTDERR:     raise ValueError('`digestmod` is required.')
BUILDSTDERR: ValueError: `digestmod` is required.
BUILDSTDERR: ======================================================================
BUILDSTDERR: FAIL: test_different_instance_callbacks (oslo_utils.tests.test_reflection.CallbackEqualityTest)
BUILDSTDERR: oslo_utils.tests.test_reflection.CallbackEqualityTest.test_different_instance_callbacks
BUILDSTDERR: ----------------------------------------------------------------------
BUILDSTDERR: testtools.testresult.real._StringException: Traceback (most recent call last):
BUILDSTDERR:   File "/builddir/build/BUILD/oslo.utils-3.40.3/oslo_utils/tests/test_reflection.py", line 156, in test_different_instance_callbacks
BUILDSTDERR:     self.assertTrue(reflection.is_same_callback(b.b, c.b, strict=False))
BUILDSTDERR:   File "/usr/lib/python3.8/site-packages/unittest2/case.py", line 702, in assertTrue
BUILDSTDERR:     raise self.failureException(msg)
BUILDSTDERR: AssertionError: False is not true
BUILDSTDERR: ----------------------------------------------------------------------
BUILDSTDERR: Ran 10636 tests in 11.488s
BUILDSTDERR: FAILED (failures=1, errors=1, skipped=4)

This issue is blocking the Python 3.8 rebuilds. If this package won't build with 3.8, it won't be installable, along with all its dependent packages, after the side tag is merged.
Furthermore, as it fails to install, its dependent packages will fail to install and/or build as well. 


The coordinated rebuild of Python 3.8 has started in the `f32-python` side tag.

If you figure out how to rebuild this package, please don't rebuild it in regular rawhide, but use the side tag instead:

    on branch master:
    $ fedpkg build --target=f32-python

To wait for a build to show up in the side tag, do:

    $ koji wait-repo f32-python --build=<nvr>

Where <nvr> is name-version-release of the source package, e.g. python-foo-1.1-2.fc32.

An updated mock config is posted at: http://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Thanks. Let us know if you need up to date info, or if you have any questions.

Comment 1 Alfredo Moralejo 2019-08-21 16:33:35 UTC

Upstream fix for one of the issues https://review.opendev.org/#/c/677770/ . I will patch in distgit.

Still investigating second one.

Comment 2 Miro Hrončok 2019-08-21 16:35:10 UTC

The f32-python side tag has been merged. In order to rebuild the package, do it in regular rawhide, but please wait until python3-3.8 is tagged:

  $ koji wait-repo f32-build --build python3-3.8.0~b3-3.fc32


If your built already started in f32-python, after it is finished, please tag it to rawhide with:

  $ koji tag-build f32-pending <nvr>

For example:

  $ koji tag-build f32-pending libreoffice-6.3.0.4-3.fc32

Thanks!

(This comment is mass posted to all bugzillas blocking the PYTHON38 tracking bug.)

Comment 3 Miro Hrončok 2019-08-21 17:29:14 UTC

(Python 3.8 has landed in the rawhide buildroot.)

Comment 4 Alfredo Moralejo 2019-08-22 15:48:08 UTC

Fixed in https://src.fedoraproject.org/rpms/python-oslo-utils/c/3eb1e84abf6cc0ea20333e70a20ba96bfdd6adce?branch=master

New package python-oslo-utils-3.40.3-4.fc32 built https://koji.fedoraproject.org/koji/taskinfo?taskID=37224417

Comment 5 Miro Hrončok 2019-08-22 15:58:30 UTC

Thanks.