Bug 1744106

Summary:	The /etc/csh.login expects environment variable PATH
Product:	[Fedora] Fedora	Reporter:	Martin Osvald 🛹 <mosvald>
Component:	setup	Assignee:	Martin Osvald 🛹 <mosvald>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	karsten, mosvald, ovasik, pknirsch
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	setup-2.13.6-1.fc30 setup-2.13.6-1.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-25 16:59:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Osvald 🛹 2019-08-21 11:03:00 UTC

This bug was initially created as a copy of Bug #1625629

I am copying this bug because: 

This will get fixed in RHEL7&8, therefore, cloning it for Fedora to prevent regression.


User was asked how the problem is triggered.
  But it is very easy to reproduce starting with *sh:

"""
[pcpa@rhel7 ~]$ unset PATH
bash: sed: No such file or directory
[pcpa@rhel7 ~]$ echo $PATH

bash: sed: No such file or directory
[pcpa@rhel7 ~]$ /bin/tcsh -l
PATH: Undefined variable.
[pcpa@rhel7 ~]$ echo $SHELL
/bin/bash
"""

  The problem started with
https://pagure.io/setup/c/78d62a2d107b61b043b712e30b0ce43cd7dcd3c0
and interestingly, setup.spec has this:

* Tue Oct 13 1998 Cristian Gafton <gafton>
- fix the csh.cshrc re: ${PATH} undefined

so, a variant of this issue likely happened before.

  The problem happens in recent Fedora and RHEL8 as well.

Comment 1 Martin Osvald 🛹 2019-08-29 07:44:32 UTC

the fix is in git, moving to MODIFIED:

https://pagure.io/setup/c/ead65179f83ba4359795055cde76c4f46417951d?branch=master

Comment 2 Martin Osvald 🛹 2019-10-08 14:59:07 UTC

CI test:

/CoreOS/setup/Regression/bz1625629-csh-expects-environment-variable-PATH

OLD: setup-2.13.3-1.fc30.noarch
NEW: setup-2.13.5-1.fc30.noarch


failed with affected OLD:

~~~
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Cleanup
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

/tmp/tmp.jIJTxmTzaI:
-----------------------
PATH: Undefined variable.
-----------------------
...
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Test for BZ#1625629 on Fedora release 30 (Thirty)
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 10:44:38 ] :: [   PASS   ] :: Command '(unset PATH; echo exit | /bin/tcsh -l; exit) 2> /tmp/tmp.jIJTxmTzaI' (Expected 0, got 0)
:: [ 10:44:38 ] :: [   FAIL   ] :: Command 'grep 'PATH: Undefined variable.' /tmp/tmp.jIJTxmTzaI' (Expected 1, got 0)
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 0s
::   Assertions: 1 good, 1 bad
::   RESULT: FAIL (Test for BZ#1625629 on Fedora release 30 (Thirty))
~~~


passed with fixed NEW:

~~~
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Cleanup
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

/tmp/tmp.RK7aFzc9H5:
-----------------------
-----------------------
...
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Test for BZ#1625629 on Fedora release 30 (Thirty)
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 10:46:20 ] :: [   PASS   ] :: Command '(unset PATH; echo exit | /bin/tcsh -l; exit) 2> /tmp/tmp.RK7aFzc9H5' (Expected 0, got 0)
:: [ 10:46:20 ] :: [   PASS   ] :: Command 'grep 'PATH: Undefined variable.' /tmp/tmp.RK7aFzc9H5' (Expected 1, got 1)
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 0s
::   Assertions: 2 good, 0 bad
::   RESULT: PASS (Test for BZ#1625629 on Fedora release 30 (Thirty))
~~~

Comment 3 Fedora Update System 2019-10-09 09:57:15 UTC

FEDORA-2019-d30f1a7dd4 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d30f1a7dd4

Comment 4 Fedora Update System 2019-10-09 09:57:16 UTC

FEDORA-2019-c423bdade3 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c423bdade3

Comment 5 Fedora Update System 2019-10-09 17:40:07 UTC

setup-2.13.6-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c423bdade3

Comment 6 Fedora Update System 2019-10-09 23:05:34 UTC

setup-2.13.6-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d30f1a7dd4

Comment 7 Fedora Update System 2019-10-25 16:59:54 UTC

setup-2.13.6-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2019-10-26 17:24:02 UTC

setup-2.13.6-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.