Bug 1744440

Summary: Unassigned buttons of a Service shows when its Catalog Item has custom buttons
Product: Red Hat CloudForms Management Engine Reporter: Zita Nemeckova <znemecko>
Component: UI - OPSAssignee: Zita Nemeckova <znemecko>
Status: CLOSED EOL QA Contact: Nikhil Dhandre <ndhandre>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.11.0CC: bmidwood, hkataria, lavenel, mpovolny, ndhandre, obarenbo
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.12.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1767646 (view as bug list) Environment:
Last Closed: 2020-03-25 18:03:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1767646    
Attachments:
Description Flags
Toolbar with unassigned Service custom button none

Description Zita Nemeckova 2019-08-22 08:08:52 UTC
Created attachment 1606862 [details]
Toolbar with unassigned Service custom button

Description of problem:
Unassigned buttons of a Service shows when its Catalog Item has custom buttons

Version-Release number of selected component (if applicable):
5.11.

How reproducible:
100%

Steps to Reproduce:
1. In Automate -> Automation -> Customization -> create an unassigned button for Services 
2. In Services -> Catalogs -> Catalog Items -> create a Catalog Item with custom button(s) or custom button group with button(s)
3. Go to Services -> Service Catalogs -> Order a created Catalog Item
4. Go to Services -> My Services and click on the ordered Service
5. See buttons in the toolbar

Actual results:
Unassigned custom buttons of a Service are displayed. See attachment. 

Expected results:
Unassigned custom buttons of a Service aren't displayed.

Additional info:
All buttons and button groups that are assigned to Catalog Item should show.

Comment 4 CFME Bot 2019-09-02 14:32:39 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/231fab8539590ef01956354ccc68eb14f2e2c042
commit 231fab8539590ef01956354ccc68eb14f2e2c042
Author:     Zita Nemeckova <znemecko>
AuthorDate: Tue Aug 20 03:59:08 2019 -0400
Commit:     Zita Nemeckova <znemecko>
CommitDate: Tue Aug 20 03:59:08 2019 -0400

    Do not show custom buttons of children of GO/ServiceTemplate in toolbar

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1744440

 app/helpers/application_helper/toolbar_builder.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)