Bug 1744528

Description of problem:

When we have the DHCP capsule server behind a firewall and the requests from port 7 which is used for checking the TCP pingable on free IP is refused. Satellite considers the IP address is used and it failed to provide the free IP (autosuggest). 

Version-Release number of selected component (if applicable):

Red Hat Satellite 6.4

Actual results:

Satellite capsule failed to provide free IP.

Expected results:

Satellite should use ping if it fails with TCP.

Additional info:

pingable code file:-
"/usr/share/foreman-proxy/modules/dhcp_common/free_ips.rb"

~~~

logger.debug "Searching for free IP - pinging #{possible_ip}."
          if tcp_pingable?(possible_ip) || icmp_pingable?(possible_ip)
            logger.debug "Found a pingable IP(#{possible_ip}) address
which does not have a Proxy::DHCP record."
          else
            logger.debug "Found free IP #{possible_ip} out of a total
of #{num_of_addresses} free IPs."
            return possible_ip
          end

~~~

As the connection is refused satellite consider the IPs is pingable
even if its free.

Tested modified code:-

~~~

          logger.debug "Searching for free IP - pinging #{possible_ip}."
          if !tcp_pingable?(possible_ip)
            logger.debug "Found free IP #{possible_ip} out of a total
of #{num_of_addresses} free IPs."
            return possible_ip
          elsif !icmp_pingable?(possible_ip)
            logger.debug "Found free IP #{possible_ip} out of a total
of #{num_of_addresses} free IPs."
            return possible_ip
          else
            logger.debug "Found a pingable IP(#{possible_ip}) address
which does not have a Proxy::DHCP record."
          end
~~~