Bug 1744583
| Summary: | Macro %undefine is a built-in | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||||
| Component: | scl-utils | Assignee: | Remi Collet <fedora> | ||||||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 31 | CC: | jnovy, jorton, kwizart, mnowak, pmatilai, pmoravco, slavek.kabrda, vondruch | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2020-01-15 10:15:13 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 1606952 [details]
Fix proposal
Created attachment 1606953 [details]
Fix proposal
Created attachment 1607005 [details]
Fix proposal
The patch is correct. (In reply to Remi Collet from comment #3) > Created attachment 1607005 [details] > Fix proposal You need to use %% in comments. Or you will have the "macro in comment" issue. Can we move ahead with the patch? I seems to suffer this bug at https://copr-be.cloud.fedoraproject.org/results/mnohime/bind-dev/fedora-31-x86_64/01120455-isc-bind-bind/builder-live.log.gz: RPM build errors: /etc/rpm/macros.isc-bind-config: line 5: Macro %undefine is a built-in (%define) /etc/rpm/macros.isc-bind-config: line 5: Macro %undefine is a built-in (%define) File not found: /builddir/build/BUILDROOT/isc-bind-bind-9.15.6-1.1.fc31.x86_64/opt/isc/isc-bind/root%{python_sitelib}/* error: /etc/rpm/macros.isc-bind-config: line 5: Macro %undefine is a built-in (%define) @Panu, do you want me to take care of merging patch proposal and run the build / updates ? Any update on this? Will use my proven packager power to fix this. FEDORA-2019-c3685a481b has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c3685a481b scl-utils-2.0.2-12.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c3685a481b I see the updated scl-utils package in the 'updates' repo, perhaps this bug should be moved to some other state. In any case it did not help our problem in comment#6 (https://copr-be.cloud.fedoraproject.org/results/mnohime/bind-dev/fedora-31-x86_64/01145028-isc-bind-bind/builder-live.log.gz): RPM build errors: /etc/rpm/macros.isc-bind-config: line 5: Macro %undefine is a built-in (%define) /etc/rpm/macros.isc-bind-config: line 5: Macro %undefine is a built-in (%define) File not found: /builddir/build/BUILDROOT/isc-bind-bind-9.15.7-1.1.fc31.x86_64/opt/isc/isc-bind/root%{python_sitelib}/* error: /etc/rpm/macros.isc-bind-config: line 5: Macro %undefine is a built-in (%define) Strange, should have been closed by Bodhi. Notice: to clear the warning, you need to rebuild the metapackage against the new version But the "File not found" issue is a different issue, probably related to python packaging. Thanks Remi the for advice. We deleted the broken F31 metapackage, rebuilt it and then the rest in the F31 Copr, and it worked. We fixed the "File not found" problem in our packaging too. |
scl-utils generate a macros-%{scl}-config file which contains overriden system macros. ex: %scl php74 %undefine nfsmountable %rh_layout 1 The %undefine generate tons of errors when this file is installed error: /usr/lib/rpm/macros.d/macros.php74-config: line 3: Macro %undefine is a built-in (%define) Deleting this line is a working workaround. Notice: error is only raised by RPM 4.15 in F31 (but even is silently ignored by older version, the line still bad and have to be removed)