Bug 1744929

Summary: [sriov] sriov device plugin pod always recreated when created 3 or more sriovnetworknodepolicies with same priority
Product: OpenShift Container Platform Reporter: zhaozhanqi <zzhao>
Component: NetworkingAssignee: Peng Liu <pliu>
Status: CLOSED ERRATA QA Contact: zhaozhanqi <zzhao>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.2.0CC: aos-bugs, bbennett
Target Milestone: ---   
Target Release: 4.2.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-10-16 06:37:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description zhaozhanqi 2019-08-23 09:36:35 UTC
Description of problem:
When created 3 sriovnetworknodepolicies with same priority, the sriov device plugin pod always recreated

Version-Release number of selected component (if applicable):
quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.2.0-201908192219-ose-sriov-network-operator
quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.2.0-201908181300-ose-sriov-network-config-daemon
quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.2.0-201908192219-ose-sriov-network-device-plugin

How reproducible:
always

Steps to Reproduce:
1. install the sriov operator
2. Create 3 sriovnetworknodepolicies with same priority
  
    #oc get sriovnetworknodepolicies policy-intel -o yaml
apiVersion: sriovnetwork.openshift.io/v1
kind: SriovNetworkNodePolicy
metadata:
  creationTimestamp: "2019-08-22T08:20:21Z"
  generation: 1
  name: policy-intel
  namespace: sriov-network-operator
  resourceVersion: "2840593"
  selfLink: /apis/sriovnetwork.openshift.io/v1/namespaces/sriov-network-operator/sriovnetworknodepolicies/policy-intel
  uid: aecd8d1a-c4b5-11e9-a6ef-3cfdfeba0aa4
spec:
  deviceType: vfio-pci
  mtu: 1500
  nicSelector:
    pfNames:
    - ens1f0
    rootDevices:
    - 0000:3b:00.0
    vendor: "8086"
  nodeSelector:
    feature.node.kubernetes.io/sriov-capable: "true"
  numVfs: 6
  priority: 99
  resourceName: intelnics2

 apiVersion: sriovnetwork.openshift.io/v1
kind: SriovNetworkNodePolicy
metadata:
  creationTimestamp: "2019-08-22T08:14:57Z"
  generation: 4
  name: policy-mt
  namespace: sriov-network-operator
  resourceVersion: "3205470"
  selfLink: /apis/sriovnetwork.openshift.io/v1/namespaces/sriov-network-operator/sriovnetworknodepolicies/policy-mt
  uid: ee0e4be5-c4b4-11e9-a6ef-3cfdfeba0aa4
spec:
  deviceType: vfio-pci
  mtu: 1500
  nicSelector:
    pfNames:
    - ens3f0
    rootDevices:
    - 0000:5e:00.0
    vendor: 15b3
  nodeSelector:
    feature.node.kubernetes.io/sriov-capable: "true"
  numVfs: 2
  priority: 99
  resourceName: mtnics

# oc get sriovnetworknodepolicies policy-mt28 -o yaml
apiVersion: sriovnetwork.openshift.io/v1
kind: SriovNetworkNodePolicy
metadata:
  creationTimestamp: "2019-08-23T04:03:54Z"
  generation: 4
  name: policy-mt28
  namespace: sriov-network-operator
  resourceVersion: "3205471"
  selfLink: /apis/sriovnetwork.openshift.io/v1/namespaces/sriov-network-operator/sriovnetworknodepolicies/policy-mt28
  uid: 06428fda-c55b-11e9-9801-3cfdfeba0aa4
spec:
  deviceType: vfio-pci
  mtu: 1500
  nicSelector:
    pfNames:
    - ens2f0
    rootDevices:
    - 0000:60:00.0
    vendor: 15b3
  nodeSelector:
    feature.node.kubernetes.io/sriov-capable: "true"
  numVfs: 6
  priority: 99
  resourceName: mt28nics
3. Check the sriov device plugin pod 

Actual results:

sriov device plugin pod always recreated

Expected results:

sriov device plugin pod work well.

Additional info:

when using different priority, no this issue.

Comment 2 zhaozhanqi 2019-09-04 09:22:22 UTC
Verified this bug on 
quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.2.0-201909020729-ose-sriov-network-operator

Comment 3 errata-xmlrpc 2019-10-16 06:37:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922