Bug 174495
| Summary: | Review Request: libopensync-plugin-kdepim | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> |
| Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list, rdieter |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.opensync.org/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-03-02 22:34:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 174486 | ||
| Bug Blocks: | 163779 | ||
|
Description
Andreas Bierfert
2005-11-29 15:42:39 UTC
1 small comment (which probably can be applied to all/most of the libopensync-plugin-* pkgs you just submitted): 1. about naming. For pkgs that provide "plugin" type services, pkg names are sometimes/often(*) rooted in what they're a plugin for, so in this case, another name for this pkg to consider is: kdepim-opensync On the other hand, I'm also a strong proponent of following upstream pkg names too (unless there is good reason to do otherwise, of course). (-: (*) precendents include addons/plugins for (off the top of my head) xmms, valgrind Maybe as provide? In my opinion, the foo-bar name means that bar enhances foo. In this case, the kdepim plugin enhances opensync more than enhances kdepim, so I's stick with the original name. (on the contrary, I didn't find any packaging errors with this plugin, but at the end of the synchronization, it pops up a kcrash dialog. I've tried adding back the *.la files and rebuilding it on my system (not in mock), but it still crashes. Any idea ? Missing end of sentence: ...(on the contrary, for the xmms-arts plugin for example, xmms is enhanced by the plugin, not arts.) (In reply to comment #3) > I didn't find any packaging errors with this plugin, but at the end of the > synchronization, it pops up a kcrash dialog. I've tried adding back the *.la > files and rebuilding it on my system (not in mock), but it still crashes. > Any idea ? What are you trying to sync? I tried evo2 <-> kdepim and it worked a bit... It has trouble with some of the entries but it did not crash... I'm syncing kdepim with a directory (file-sync plugin). Sometimes it pops up the kcrash dialog : The sync was successful KCrash: Application 'libopensync-kdepim-plugin' crashing... Sometimes it ouputs: The sync was successful *** glibc detected *** msynctool: free(): invalid pointer: 0x08eff0c0 *** And stops there. It does not seem to be related to packaging, so it should not block this package (opensync, and particularly the kde plugin, is under heavy development at the moment). But you'll be the one assigned to bug reports, so be prepared... :) sure... but then I will bug upstream with it ;) So what shall we do with this? =) Fine by me if we push this and take reported matters upstream... Alright then. Review for release 1: * RPM name is OK * Builds fine in mock * rpmlint of libopensync-plugin-kdepim looks OK * File list of libopensync-plugin-kdepim looks OK * Tarball has the same MD5SUM as upstream * Works (most of the time :) ) APPROVED Imported, fixed ;), pushed. Thanks for the review... |