Bug 174504
| Summary: | Review Request: wine-docs - Documentation for wine | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> |
| Component: | Package Review | Assignee: | Linus Walleij <triad> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.winehq.org | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-31 22:10:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Andreas Bierfert
2005-11-29 16:16:58 UTC
New version: http://fedora.lowlatency.de/review/wine-docs.spec http://fedora.lowlatency.de/review/wine-docs-0.9.3-1.src.rpm New version: http://fedora.lowlatency.de/review/wine-docs.spec http://fedora.lowlatency.de/review/wine-docs-0.9.4-1.src.rpm New version: http://fedora.lowlatency.de/review/wine-docs.spec http://fedora.lowlatency.de/review/wine-docs-0.9.4-1.src.rpm New version: http://fedora.lowlatency.de/review/wine-docs.spec http://fedora.lowlatency.de/review/wine-docs-0.9.5-1.src.rpm Lint results: # rpmlint wine-docs-0.9.5-1.src.rpm E: wine-docs configure-without-libdir-spec - could be ignored, nothing libbed here. # rpmlint wine-docs-0.9.5-1.noarch.rpm W: wine-docs no-version-in-last-changelog That thing again. Not much to care about here. Docs are placed in /usr/share/doc/wine-docs-0.9.5, perhaps one would prefer /usr/share/doc/wine-0.9.5 but who cares. GOOD: * Package name matches spec file name * Meets package naming guidelines (child package docs) * FLOSS-compatible license (LGPL) * spec file is in american english * spec file is readable indeed * sources match upstream (MD5SUM is the same) * builds fine on FC4 * no exceptionized BuildRequires * all build dependencies listed * no locale magic needed * no libraries installed * non-relocatable * owns its directories (implicit since %doc tag is used) * no duplicate files * proper permissions on files * proper %clean section * proper use of macros I think, should %configure be used instead of ./configure? NEEDSWORK: * License field is wrong: tagged GPL but is LGPL (COPYING.LIB) * The license file MUST be %doc:ed Fix these and it's a go... Fixed the NEEDSWORK things... as to configure: If I remeber correctly it failed with %configure ... Here you go and thanks for your time :) http://fedora.lowlatency.de/review/wine-docs.spec http://fedora.lowlatency.de/review/wine-docs-0.9.5-2.src.rpm APPROVED. Thanks again :) build for fc5. Package Change Request ====================== Package Name: wine-docs New Branches: EL-5 Package Change Request ====================== Package Name: wine-docs New Branches: EL-4 cvs done. |