Bug 174588
| Summary: | Review Request: libopensync-plugin-gpe | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.opensync.org/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-02-27 23:51:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 174486 | ||
| Bug Blocks: | 163779 | ||
|
Description
Andreas Bierfert
2005-11-30 14:49:19 UTC
Minor: - warnings while building: gpesync_client.c: In function 'write_command': gpesync_client.c:70: warning: ignoring return value of 'write', declared with attribute warn_unused_result gpesync_client.c: In function 'gpesync_client_open': gpesync_client.c:248: warning: ignoring return value of 'pipe', declared with attribute warn_unused_result gpesync_client.c:249: warning: ignoring return value of 'pipe', declared with attribute warn_unused_result It'd be nice if these went away and we could use -Werror again. File a bug upstream. - %description too long rpmlint of libopensync-plugin-gpe-devel-0.18-1.i386.rpm:E: libopensync-plugin-gpe-devel description-line-too-long The libopensync-plugin-gpe-devel package contains the files needed for development rpmlint of libopensync-plugin-gpe-devel-0.18-1.i386.rpm:E: libopensync-plugin-gpe-devel description-line-too-long The libopensync-plugin-gpe-devel package contains the files needed for development Good: - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC4 i386 - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Fixup the %description and this is APPROVED Here is a fixed version :) http://fedora.lowlatency.de/review/libopensync-plugin-gpe-0.18-2.src.rpm http://fedora.lowlatency.de/review/libopensync-plugin-gpe.spec Fixed version also builds on x86_64 rawhide. APPROVED Thanks. Imported and pushed :) |