Bug 1746016

Summary:	[osp] machine-controller logs unuseful info
Product:	OpenShift Container Platform	Reporter:	sunzhaohua <zhsun>
Component:	Cloud Compute	Assignee:	Mike Fedosin <mfedosin>
Status:	CLOSED ERRATA	QA Contact:	sunzhaohua <zhsun>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.2.0	CC:	agarcial, eduen, jchaloup
Target Milestone:	---
Target Release:	4.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	osp
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-16 06:37:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description sunzhaohua 2019-08-27 13:28:21 UTC

Description of problem:
machine-controller logs below info:

I0827 05:47:31.921883       1 actuator.go:325] re-creating machine  for update.
E0827 05:47:31.922007       1 actuator.go:328] delete machine  for update failed: Failed to get Machine Spec from Provider Spec (clients/machineservice.go 138): no such providerSpec found in manifest

Version-Release number of selected component (if applicable):
4.2.0-0.nightly-2019-08-22-153337

How reproducible:
always

Steps to Reproduce:
1. Check machine-controller logs
2.
3.

Actual results:

$ oc logs -f machine-api-controllers-7c795d5746-kpn4v -c machine-controller
I0827 05:47:31.286897       1 controller.go:129] Reconciling Machine "shared-jiazha-8ck2c-worker1-sbvz7"
I0827 05:47:31.287103       1 controller.go:298] Machine "shared-jiazha-8ck2c-worker1-sbvz7" in namespace "openshift-machine-api" doesn't specify "cluster.k8s.io/cluster-name" label, assuming nil cluster
I0827 05:47:31.921304       1 controller.go:238] Reconciling machine "shared-jiazha-8ck2c-worker1-sbvz7" triggers idempotent update
I0827 05:47:31.921883       1 actuator.go:325] re-creating machine  for update.
E0827 05:47:31.922007       1 actuator.go:328] delete machine  for update failed: Failed to get Machine Spec from Provider Spec (clients/machineservice.go 138): no such providerSpec found in manifest
I0827 05:48:11.360955       1 controller.go:129] Reconciling Machine "shared-jiazha-8ck2c-worker1-sbvz7"
I0827 05:48:11.363004       1 controller.go:298] Machine "shared-jiazha-8ck2c-worker1-sbvz7" in namespace "openshift-machine-api" doesn't specify "cluster.k8s.io/cluster-name" label, assuming nil cluster
I0827 05:48:11.984197       1 controller.go:238] Reconciling machine "shared-jiazha-8ck2c-worker1-sbvz7" triggers idempotent update
I0827 05:48:11.984695       1 actuator.go:325] re-creating machine  for update.
E0827 05:48:11.984859       1 actuator.go:328] delete machine  for update failed: Failed to get Machine Spec from Provider Spec (clients/machineservice.go 138): no such providerSpec found in manifest

Expected results:
No such unusful info.

Additional info:

Comment 1 Mike Fedosin 2019-09-03 12:38:22 UTC

hi! this should be fixed by https://github.com/openshift/cluster-api-provider-openstack/pull/61

the error happend because we used the upstream API version for OpenShift machines, and therefore coudln't convert the provider spec. after the API change I don't see these messages in the logs.

Comment 2 sunzhaohua 2019-09-04 02:15:28 UTC

Verified.
4.2.0-0.nightly-2019-09-02-172410

I0903 08:53:35.830059       1 controller.go:238] Reconciling machine "share-0903c-xc62h-worker-test" triggers idempotent update
I0903 08:53:36.500589       1 actuator.go:297] Populating current state for boostrap machine share-0903c-xc62h-worker-test
I0903 08:53:37.225501       1 controller.go:129] Reconciling Machine "share-0903c-xc62h-worker-test"
I0903 08:53:37.225689       1 controller.go:298] Machine "share-0903c-xc62h-worker-test" in namespace "openshift-machine-api" doesn't specify "cluster.k8s.io/cluster-name" label, assuming nil cluster
I0903 08:53:37.762121       1 controller.go:238] Reconciling machine "share-0903c-xc62h-worker-test" triggers idempotent update
I0903 08:59:08.941523       1 controller.go:129] Reconciling Machine "share-0903c-xc62h-worker-test"
I0903 08:59:08.941734       1 controller.go:298] Machine "share-0903c-xc62h-worker-test" in namespace "openshift-machine-api" doesn't specify "cluster.k8s.io/cluster-name" label, assuming nil cluster
I0903 08:59:09.401215       1 controller.go:238] Reconciling machine "share-0903c-xc62h-worker-test" triggers idempotent update
I0903 08:59:09.401616       1 controller.go:129] Reconciling Machine "share-0903c-xc62h-worker-test"
I0903 08:59:09.401646       1 controller.go:298] Machine "share-0903c-xc62h-worker-test" in namespace "openshift-machine-api" doesn't specify "cluster.k8s.io/cluster-name" label, assuming nil cluster

Comment 3 errata-xmlrpc 2019-10-16 06:37:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922