Bug 1746319

Summary: hid_field_extract() spams dmesg
Product: [Fedora] Fedora Reporter: Didier <d.bz-redhat>
Component: kernelAssignee: Kernel Maintainer List <kernel-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 30CC: airlied, bskeggs, eliadevito, fattony4, hdegoede, ichavero, itamar, jarodwilson, jeremy, jglisse, john.j5live, jonathan, josef, kernel-maint, linville, masami256, mchehab, mjg59, ryan, steved
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-03 17:03:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
dmesg output none

Description Didier 2019-08-28 07:31:07 UTC 
kernel-5.2.9-200.fc30.x86_64

Kernel logs are spammed (= tens of messages per second) with :

kernel: hid-sensor-hub 001F:8087:0AC2.0003: hid_field_extract() called with n (192) > 32! (kworker/7:0)



This is a kernel bug, also reported with several other distributions (e.g. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1818547)




Reported at LKML : https://lkml.org/lkml/2019/3/8/2
Fixed : https://lkml.org/lkml/2019/3/8/2
Reverted : https://lkml.org/lkml/2019/4/25/848

Suggested workaround  ("only warn once") :
https://lkml.org/lkml/2019/5/21/834

Workaround :
https://lkml.org/lkml/2019/8/12/740


Would it be possible to include/backport the workaround in the current 5.2.x releases ?
Comment 1 ryan@testtoast.com 2019-09-11 20:13:31 UTC 
+1 for implementing the warn_once workaround, this bug is also an issue on my X1 Yoga and makes reading the kernel log almost impossible. I understand the actual fix of increasing the field size requires further work upstream, but it would be great to suppress the (useless IMHO) log spam.
Comment 2 Didier 2019-09-27 13:57:32 UTC 
This problem still applies to Fedora's kernel 5.3.0-200.fc30.x86_64.
Comment 3 fattony4 2019-09-28 11:27:12 UTC 
Problem persists in 5.3.1-300.fc31.x86_64.
Comment 4 ryan@testtoast.com 2019-09-28 11:53:43 UTC 
Fixed upstream by commit 1ad0bc78948652edc3067b6b49ba31b1598faa4a

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid: (27 commits)
  HID: core: fix dmesg flooding if report field larger than 32bit
  HID: core: Add printk_once variants to hid_warn() etc

Would be nice if this could be backported to 5.3.
Comment 5 Didier 2019-10-11 12:14:48 UTC 
Created attachment 1624728 [details]
dmesg output

This issue is still present in 5.3.5-200.fc30.x86_64 : 

dmesg/journald/rsyslog is hit by about 40 superfluous warnings/second.
Comment 6 Didier 2019-11-28 17:35:01 UTC 
The problem persists in kernel-5.3.11-200.fc30.x86_64.

The issue is resolved in kernel-5.4.0-2.vanilla.knurd.1.fc30.x86_64 (installed from the kernel-vanilla-stable repository, as described at https://fedoraproject.org/wiki/Kernel_Vanilla_Repositories).
Comment 7 Justin M. Forbes 2020-03-03 16:33:07 UTC 
*********** MASS BUG UPDATE **************

We apologize for the inconvenience.  There are a large number of bugs to go through and several of them have gone stale.  Due to this, we are doing a mass bug update across all of the Fedora 30 kernel bugs.

Fedora 30 has now been rebased to 5.5.7-100.fc30.  Please test this kernel update (or newer) and let us know if you issue has been resolved or if it is still present with the newer kernel.

If you have moved on to Fedora 31, and are still experiencing this issue, please change the version to Fedora 31.

If you experience different issues, please open a new bug report for those.
Comment 8 Didier 2020-03-03 17:03:20 UTC 
F30 being rebased to 5.5.x, this bug is resolved.