Bug 1747622
| Summary: | Review Request: golang-github-cmd - Go library wrapper around os/exec.Cmd | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Carl George 🤠<carlwgeorge> |
| Component: | Package Review | Assignee: | Elliott Sales de Andrade <quantum.analyst> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, quantum.analyst |
| Target Milestone: | --- | Flags: | quantum.analyst:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-09-14 00:10:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1747843 | ||
| Bug Blocks: | 1747626 | ||
|
Description
Carl George ðŸ¤
2019-08-31 08:05:29 UTC
Looks like you need https://github.com/go-test/deep to run tests, though they don't run right now due to a bug. Ah, I see that now, good catch. Odd that it built without it. go2rpm doesn't detect it either. Oh well, I've submitted it too, see bug 1747843. Oh I almost forgot, here is the new spec/srpm for this one with that build requirement added. Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01026802-golang-github-cmd/golang-github-cmd.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01026802-golang-github-cmd/golang-github-cmd-1.0.5-2.fc32.src.rpm When running tests now, one of them fails:
--- FAIL: TestCmdNotFound (0.00s)
cmd_test.go:272: {Cmd:cmd-does-not-exist PID:0 Complete:false Exit:-1 Error:exec: "cmd-does-not-exist": executable file not found in $PATH StartTs:0 StopTs:0 Runtime:0 Stdout:[] Stderr:[]}
cmd_test.go:273: [Error: *exec.Error != *errors.errorString]
I guess this might be a bug in deep against Go 1.13, maybe? It seems to be incorrectly comparing the expected Error types.
I'll approve this, but keep in mind that tests will start failing once https://pagure.io/go-rpm-macros/pull-request/20 is shipped out. Works for me, I'll cross that bridge when I come to it. Perhaps by that time if it is a bug in Go itself it will have been resolved. Thanks Elliott! FEDORA-2019-57802931dd has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-57802931dd golang-github-cmd-1.0.5-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-57802931dd golang-github-cmd-1.0.5-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. golang-github-cmd-1.0.5-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. |