Bug 1747700

Summary: Compile with support for KeeShare signed sharing
Product: [Fedora] Fedora Reporter: strasharo2000
Component: keepassxcAssignee: Germano Massullo (Thetra) <germano.massullo>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 30CC: germano.massullo, nonamedotc
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: keepassxc-2.4.3-4.fc30 keepassxc-2.4.3-4.fc29 keepassxc-2.4.3-6.fc31 keepassxc-2.4.3-4.el8 keepassxc-2.4.3-6.fc30 keepassxc-2.4.3-6.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1754062 (view as bug list) Environment:
Last Closed: 2019-09-21 00:02:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description strasharo2000 2019-08-31 20:14:59 UTC
Description of problem:

Currently it appears that the package in Fedora 30 is compiled without support for signed sharing. This is in the about box:

- KeeShare (only unsigned sharing)



Version-Release number of selected component (if applicable):
keepassxc-2.4.3-1.fc30.x86_64

How reproducible:
Check the "Debug info" tab in the about box in the "Enabled extensions" section.

Steps to Reproduce:
1. Open KeePassXC
2. Click Tools - Settings
3. Click on KeeShare on the left

Actual results:

The generate and import buttons for certificates are not there.

Expected results:
The generate and import certificate buttons should be available.


Additional info:
Support can be enabled with -DWITH_XC_KEESHARE_SECURE=ON

As noted here:
https://github.com/keepassxreboot/keepassxc/issues/2761#issuecomment-478384361

"You need to compile with -DWITH_XC_KEESHARE_SECURE=ON. It's not included in -DWITH_XC_ALL as of yet."

Comment 1 Fedora Update System 2019-09-05 11:50:37 UTC
FEDORA-2019-0829f58907 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0829f58907

Comment 2 Fedora Update System 2019-09-05 11:52:41 UTC
FEDORA-EPEL-2019-c11c070660 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-c11c070660

Comment 3 Fedora Update System 2019-09-05 11:52:58 UTC
FEDORA-2019-9188f20552 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9188f20552

Comment 4 Fedora Update System 2019-09-05 11:53:01 UTC
FEDORA-2019-6c31be5f83 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6c31be5f83

Comment 5 Fedora Update System 2019-09-06 00:22:26 UTC
keepassxc-2.4.3-4.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6c31be5f83

Comment 6 Fedora Update System 2019-09-06 12:11:06 UTC
keepassxc-2.4.3-4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9188f20552

Comment 7 Fedora Update System 2019-09-06 13:21:25 UTC
keepassxc-2.4.3-4.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0829f58907

Comment 8 Fedora Update System 2019-09-06 16:16:18 UTC
keepassxc-2.4.3-4.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-c11c070660

Comment 9 strasharo2000 2019-09-12 20:20:03 UTC
Tried the package from here https://kojipkgs.fedoraproject.org//packages/keepassxc/2.4.3/4.fc30/x86_64/keepassxc-2.4.3-4.fc30.x86_64.rpm , but in the debug info it still states:

- KeeShare (only unsigned sharing)

Comment 10 Germano Massullo (Thetra) 2019-09-12 20:23:06 UTC
(In reply to strasharo2000 from comment #9)
> Tried the package from here
> https://kojipkgs.fedoraproject.org//packages/keepassxc/2.4.3/4.fc30/x86_64/
> keepassxc-2.4.3-4.fc30.x86_64.rpm , but in the debug info it still states:
> 
> - KeeShare (only unsigned sharing)

Then contact upstream developers because I don't know what we can do on packaging side

Comment 11 strasharo2000 2019-09-12 21:27:17 UTC
It requires quazip-devel to be installed:

-- Could NOT find QUAZIP (missing: QUAZIP_LIBRARIES QUAZIP_INCLUDE_DIR) 
-- KeeShare: Secure container support is DISABLED; quazip library not found

Installed quazip-devel and rebuilt the package from here:
https://kojipkgs.fedoraproject.org//packages/keepassxc/2.4.3/4.fc30/src/keepassxc-2.4.3-4.fc30.src.rpm

And now it has the support enabled:
- KeeShare (signed and unsigned sharing)

Comment 12 Fedora Update System 2019-09-14 01:12:14 UTC
keepassxc-2.4.3-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2019-09-14 01:54:19 UTC
keepassxc-2.4.3-4.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 strasharo2000 2019-09-14 08:19:17 UTC
It requires the quazip-devel package to be presenet during compile time, 2.4.3-4 pushed to stable still doesn't have the support for signed sharing.

Comment 15 Fedora Update System 2019-09-16 10:57:30 UTC
FEDORA-2019-93958b48da has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-93958b48da

Comment 16 Fedora Update System 2019-09-16 10:57:34 UTC
FEDORA-2019-8bc3e73f2b has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8bc3e73f2b

Comment 17 Fedora Update System 2019-09-16 10:57:34 UTC
FEDORA-2019-bbb08b715f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2019-bbb08b715f

Comment 18 Fedora Update System 2019-09-17 01:23:17 UTC
keepassxc-2.4.3-5.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0e88e77988

Comment 19 Fedora Update System 2019-09-17 02:10:04 UTC
keepassxc-2.4.3-5.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-93958b48da

Comment 20 Fedora Update System 2019-09-17 02:14:27 UTC
keepassxc-2.4.3-5.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8bc3e73f2b

Comment 21 strasharo2000 2019-09-17 06:42:57 UTC
Signed sharing support is present in keepassxc-2.4.3-5.fc30.x86_64, thanks a lot.

Comment 22 Germano Massullo (Thetra) 2019-09-19 11:51:31 UTC
In new updates I replaced BuildRequires: quazip-devel with BuildRequires: quazip-qt5-devel

Comment 23 Fedora Update System 2019-09-19 14:29:27 UTC
FEDORA-2019-c93fc5bd3c has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c93fc5bd3c

Comment 24 Fedora Update System 2019-09-19 14:29:33 UTC
FEDORA-2019-cbb3074eac has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-cbb3074eac

Comment 25 Fedora Update System 2019-09-20 01:56:52 UTC
keepassxc-2.4.3-6.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c902ca4e32

Comment 26 Fedora Update System 2019-09-20 02:56:50 UTC
keepassxc-2.4.3-6.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c93fc5bd3c

Comment 27 Fedora Update System 2019-09-20 03:01:59 UTC
keepassxc-2.4.3-6.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-cbb3074eac

Comment 28 Fedora Update System 2019-09-21 00:02:53 UTC
keepassxc-2.4.3-6.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 29 Fedora Update System 2019-09-21 02:04:22 UTC
keepassxc-2.4.3-4.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report.

Comment 30 Fedora Update System 2019-09-22 02:26:02 UTC
keepassxc-2.4.3-6.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 31 Fedora Update System 2019-09-28 01:56:24 UTC
keepassxc-2.4.3-6.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.