Bug 1747811

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01026730-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator.spec

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01026730-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator-30-2.fc30.src.rpm

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01026833-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator.spec

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01026833-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator-30-3.fc30.src.rpm

Not sure about 'indicator-test-tool/ksni.py' because of python2. But we can delete this test safely.

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01026836-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator.spec

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01026836-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator-30-4.fc30.src.rpm

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01026842-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator.spec

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01026842-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator-30-5.fc30.src.rpm

# FIXME

You can use gnome-tweak-tool (additional package) or run in terminal:
→
You can use gnome-tweaks (additional package) or run in terminal:

gnome-tweak-tool - is legacy name. I will fix this in next build before import.

I will review this package.

1. Ask upstream to add license files.
2. Python 2 is deprecated and must not be used in Rawhide. Please ask upstream to port scripts to Python 3 or do it manually and then send PR to upstream.
3. Patches should be applied in %prep.
4. Use sed -i 's!/bin/env python2!%{__python3}!' indicator-test-tool/ksni.py instead of hardcoding path.
5. I think it will be better to use /usr/bin/install with explicitly set chmod instead of just copying files to destination directory.

(In reply to Vitaly Zaitsev from comment #7)

1. Done
2. TODO
3. Done
4. Done
5. TODO

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01028680-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator.spec

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01028680-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator-30-6.fc30.src.rpm

I found that this legacy test tools not working with python3 and as for python2 they requires a tons of old KDE4 libs and packages and requires at least to install:

  - PyQt4
  - PyKDE4

Maybe better delete them at all or made a separate package...

> Maybe better delete them at all or made a separate package...

Python 2 is not allowed for Rawhide. This script must be removed then.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* GPL (v2 or later)". 10
     files have unknown license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gnome-shell-extension-appindicator-30-6.fc32.noarch.rpm
          gnome-shell-extension-appindicator-30-6.fc32.src.rpm
gnome-shell-extension-appindicator.noarch: W: spelling-error %description -l en_US systray -> stray
gnome-shell-extension-appindicator.src: W: spelling-error %description -l en_US systray -> stray
gnome-shell-extension-appindicator.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_US.utf8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_US.utf8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
gnome-shell-extension-appindicator.noarch: W: spelling-error %description -l en_US systray -> stray
gnome-shell-extension-appindicator.noarch: W: invalid-url URL: https://github.com/ubuntu/gnome-shell-extension-appindicator <urlopen error [Errno -2] Name or service not known>
1 packages and 0 specfiles checked; 0 errors, 2 warnings.



Source checksums
----------------
https://github.com/ubuntu/gnome-shell-extension-appindicator/archive/v30/gnome-shell-extension-appindicator-30.tar.gz :
  CHECKSUM(SHA256) this package     : 2c6ec035ea18a042d7854233110e03c4a055b09240c1b7da8c729ff4e2032f75
  CHECKSUM(SHA256) upstream package : 2c6ec035ea18a042d7854233110e03c4a055b09240c1b7da8c729ff4e2032f75


Requires
--------
gnome-shell-extension-appindicator (rpmlib, GLIBC filtered):
    /usr/bin/gjs
    /usr/bin/python3
    gnome-shell



Provides
--------
gnome-shell-extension-appindicator:
    gnome-shell-extension-appindicator



Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09
Command line :/usr/bin/fedora-review -b 1747811 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Perl, Python, PHP, C/C++, Ocaml, Haskell, R, Java, SugarActivity, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

LGTM now. Package approved.

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01028684-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator.spec

https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-appindicator/fedora-30-x86_64/01028684-gnome-shell-extension-appindicator/gnome-shell-extension-appindicator-30-7.fc30.src.rpm

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-appindicator

FEDORA-2019-8c088914dd has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8c088914dd

FEDORA-2019-925cbcb6fe has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-925cbcb6fe

FEDORA-2019-0afb6633c8 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0afb6633c8

FEDORA-EPEL-2019-b15221e733 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-b15221e733

gnome-shell-extension-appindicator-30-7.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8c088914dd

gnome-shell-extension-appindicator-30-7.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-925cbcb6fe

gnome-shell-extension-appindicator-30-7.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-b15221e733

gnome-shell-extension-appindicator-30-7.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

gnome-shell-extension-appindicator-30-7.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

gnome-shell-extension-appindicator-30-7.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report.