Bug 1747853

Summary:	Review Request: golang-github-captncraig-caddy-realip - Real-IP middleware for caddy
Product:	[Fedora] Fedora	Reporter:	Carl George <carlwgeorge>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-02 00:46:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1672781
Bug Blocks:

Description Carl George 2019-09-02 04:35:58 UTC

Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01026177-golang-github-captncraig-caddy-realip/golang-github-captncraig-caddy-realip.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01026177-golang-github-captncraig-caddy-realip/golang-github-captncraig-caddy-realip-0-0.1.20190828git6df827e.fc32.src.rpm

Description:
Middleware for restoring real ip information when running caddy behind a proxy.
Will allow other middlewares to simply use r.RemoteAddr instead of decoding
X-Forwarded-For themselves. Analogous to the realip_module in nginx.

Fedora Account System Username: carlwgeorge

Comment 1 Carl George 2019-09-07 08:02:58 UTC

The dependencies should now be in the rawhide and F31 buildroots, so fedora-review should be able to run on this now.

https://bodhi.fedoraproject.org/updates/FEDORA-2019-d420352475 (caddy-1.0.3-1.fc32~bootstrap)

https://bodhi.fedoraproject.org/overrides/caddy-1.0.3-1.fc31~bootstrap

Comment 2 Robert-André Mauchin 🐧 2019-09-19 14:23:17 UTC

 - Fix the Release info in your %changelog entry:

* Sat Aug 31 2019 Carl George <carl> - 0-0.1.20190919git6df827e

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 3 Carl George 2019-09-19 18:58:56 UTC

> - Fix the Release info in your %changelog entry:

Is that still a requirement?  I noticed the new go macros do that automatically by overriding %dist.  Compare the release to the filename of the source RPM.

Release:        0.1%{?dist}

golang-github-captncraig-caddy-realip-0-0.1.20190828git6df827e.fc32.src.rpm

Including the build date in the release field results in it being in the release twice, so I removed it there.  At that point including that in the changelog seems problematic because it would be easy to get out of sync with the actual build date.

Comment 4 Gwyn Ciesla 2019-09-19 19:47:35 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-captncraig-caddy-realip

Comment 5 Fedora Update System 2019-09-22 19:15:03 UTC

FEDORA-2019-ef43b7bb8f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ef43b7bb8f

Comment 6 Fedora Update System 2019-09-24 01:23:33 UTC

golang-github-captncraig-caddy-realip-0-0.1.20190922git6df827e.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ef43b7bb8f

Comment 7 Fedora Update System 2019-10-02 00:46:19 UTC

golang-github-captncraig-caddy-realip-0-0.1.20190922git6df827e.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.