Bug 1747972
| Summary: | Disable libbluray dependency | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Bastien Nocera <bnocera> |
| Component: | gvfs | Assignee: | Ondrej Holy <oholy> |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 8.0 | CC: | gary.buhrmaster, jkoten, tpelka |
| Target Milestone: | rc | ||
| Target Release: | 8.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | gvfs-1.36.2-7.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-04-28 16:09:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Bastien Nocera
2019-09-02 11:17:40 UTC
Is there a reason you don't simply change the name of the library (and rpm) in RHEL8? It seems a shame to remove the functionality from gvfs. Changing it to something like liblibblurayrht.so would clear the way for EPEL and/or the CentOS SIGs to ship libbluray and libbluray-devel. (In reply to Kaleb KEITHLEY from comment #1) > Is there a reason you don't simply change the name of the library (and rpm) > in RHEL8? > > It seems a shame to remove the functionality from gvfs. > > Changing it to something like liblibblurayrht.so would clear the way for > EPEL and/or the CentOS SIGs to ship libbluray and libbluray-devel. It would be far more work than the functionality warrants. Ideally, we'd replace the functionality with an open-coded/more targeted version, but seeing as, when I originally wrote the functionality, it was already super-niche, I don't see the point spending any more time over this. That makes sense to me. I've pushed this change into Fedora already: https://src.fedoraproject.org/rpms/gvfs/c/eb670572bbca78f542a8c3f49c95afa8f0d3c8de (In reply to Ondrej Holy from comment #4) > I've pushed this change into Fedora already: > https://src.fedoraproject.org/rpms/gvfs/c/ > eb670572bbca78f542a8c3f49c95afa8f0d3c8de I don't see a reason for that change to happen in Fedora. The reasoning behind disabling that dependency was for RHEL, not Fedora. To make it clear, I haven't removed libbluray dependency from Fedora package, I only added changes like %if 0%{?rhel} -Dbluray=false %endif in order to simplify future maintenance...
(In reply to Ondrej Holy from comment #6) > To make it clear, I haven't removed libbluray dependency from Fedora > package, I only added changes like %if 0%{?rhel} -Dbluray=false %endif in > order to simplify future maintenance... I should have checked the code directly. So that's perfect, thanks! Will someone (at RH) be removing libbluray from EL8 in order that EPEL8 may build/package libbluray without violating the don't duplicate rules? Is there an existing ticket I can follow and reference for the removal (and then reference in an EPEL8 request)? (In reply to Bastien Nocera from comment #0) > ... > As the playback portions of libbluray aren't used in RHEL and we don't ship > the devel package to build against what's possibly an outdated version of > the library FWIW, there was a request to ship libbluray-devel (following the process requested for consolidation of -devel packages for EL8) made via https://pagure.io/epel/issue/61 which perhaps should be amended/canceled if libbluray is to move to EPEL8. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:1766 |