Bug 1748449

Summary:	[RFE] Issue a warning that upgrade playbook is in tech preview
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Patric Uebele <puebele>
Component:	cns-ansible	Assignee:	Daniel Pivonka <dpivonka>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Arun Kumar <arukumar>
Severity:	medium	Docs Contact:
Priority:	high
Version:	unspecified	CC:	arukumar, dpivonka, hchiramm, knarra, kramdoss, madam, rcyriac, rhs-bugs, rtalur, sarumuga, ykaul
Target Milestone:	---	Keywords:	ZStream
Target Release:	OCS 3.11.z Batch Update 4
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	openshift-ansible-3.11.147-1	Doc Type:	Technology Preview
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-13 05:22:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1703695

Description Patric Uebele 2019-09-03 15:44:52 UTC

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36
Build Identifier: 

While the OCSansible upgrade playbooks are still in tech preview, make the OCS upgrade playbooks issue a warning clarifying the tech preview state. If 

Reproducible: Always

Comment 2 Yaniv Kaul 2019-09-04 06:30:24 UTC

We should have a new default assignee?

Comment 5 Daniel Pivonka 2019-09-16 17:55:09 UTC

PR: https://github.com/openshift/openshift-ansible/pull/11905

Comment 6 Daniel Pivonka 2019-09-30 15:39:53 UTC

PR: https://github.com/openshift/openshift-ansible/pull/11930

made a mistake in the error message.

Comment 7 Daniel Pivonka 2019-09-30 19:07:36 UTC

PR merged

Comment 8 Daniel Pivonka 2019-10-03 15:01:43 UTC

fixed in version updated

Comment 9 Arun Kumar 2019-10-07 11:57:24 UTC

I have verferied the bug playbook is working as expected and moving it to verfied state. Snnipet of inventory file variables and ansible logs is as follows:

version:
========
[root@master ~]# rpm -qa|grep ansible
openshift-ansible-playbooks-3.11.147-1.git.0.bd6c010.el7.noarch
ansible-2.6.19-1.el7ae.noarch
openshift-ansible-3.11.147-1.git.0.bd6c010.el7.noarch
openshift-ansible-roles-3.11.147-1.git.0.bd6c010.el7.noarch
openshift-ansible-docs-3.11.147-1.git.0.bd6c010.el7.noarch

Case 1: No variable set in the inventory file
=============================================
ansible logs:
-------------
TASK [Check if user acknowledged that upgrade playbook is in tech preview] **************************************************************************************************
task path: /usr/share/ansible/openshift-ansible/playbooks/openshift-glusterfs/upgrade.yml:7
fatal: [master]: FAILED! => {
    "changed": false, 
    "msg": "Upgrade playbook is in tech preview, please define var openshift_storage_gluster_update_techpreview=true to proceed"
}

NO MORE HOSTS LEFT **********************************************************************************************************************************************************
	to retry, use: --limit @/usr/share/ansible/openshift-ansible/playbooks/openshift-glusterfs/upgrade.retry

PLAY RECAP ******************************************************************************************************************************************************************
master                     : ok=0    changed=0    unreachable=0    failed=1  


Case 2: varaible set to false
=============================
inventory file  arguments:
--------------------------
openshift_storage_glusterfs_block_host_vol_size=100
openshift_storage_glusterfs_timeout=50
openshift_storage_gluster_update_techpreview=false

ansible logs:
-------------
TASK [Check if user acknowledged that upgrade playbook is in tech preview] **************************************************************************************************
task path: /usr/share/ansible/openshift-ansible/playbooks/openshift-glusterfs/upgrade.yml:7
fatal: [master]: FAILED! => {
    "changed": false, 
    "msg": "Upgrade playbook is in tech preview, please define var openshift_storage_gluster_update_techpreview=true to proceed"
}

NO MORE HOSTS LEFT **********************************************************************************************************************************************************
	to retry, use: --limit @/usr/share/ansible/openshift-ansible/playbooks/openshift-glusterfs/upgrade.retry

PLAY RECAP ******************************************************************************************************************************************************************
master                     : ok=0    changed=0    unreachable=0    failed=1 


Case 3: varaible set to true
============================
inventory file  arguments:
---------------------------
openshift_storage_glusterfs_block_host_vol_size=100
openshift_storage_glusterfs_timeout=50
openshift_storage_gluster_update_techpreview=true

ansible logs:
-------------
TASK [Check if user acknowledged that upgrade playbook is in tech preview] **************************************************************************************************
task path: /usr/share/ansible/openshift-ansible/playbooks/openshift-glusterfs/upgrade.yml:7
skipping: [master] => {
    "changed": false, 
    "skip_reason": "Conditional result was False"
}
META: ran handlers
META: ran handlers

PLAY [Initialization Checkpoint Start] **************************************************************************************************************************************
META: ran handlers