Bug 1748494

Summary:	Tor Browser Launcher is missing in GNOME Software
Product:	[Fedora] Fedora	Reporter:	AsciiWolf <mail>
Component:	torbrowser-launcher	Assignee:	Gwyn Ciesla <gwync>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	30	CC:	gwync, pj.pandit
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	torbrowser-launcher-0.3.2-7.fc30 torbrowser-launcher-0.3.2-7.fc31 torbrowser-launcher-0.3.2-10.fc30 torbrowser-launcher-0.3.2-10.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-09-08 02:59:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description AsciiWolf 2019-09-03 17:34:43 UTC

Description of problem:
Tor Browser Launcher cannot be found using GNOME Software in Fedora 30. It seems that there is something wrong with its AppStream metadata.

Version-Release number of selected component (if applicable):
torbrowser-launcher-0.3.2-1.fc30.noarch

How reproducible:
Every time.

Steps to Reproduce:
1. Use clean, fully update Fedora 30 system.
2. Open the "Software" application.
3. Try searching for Tor Browser.

Actual results:
Tor Browser Launcher is not found.

Expected results:
Tor Browser Launcher is found.

Additional info:
It may be related to this issue: https://github.com/micahflee/torbrowser-launcher/issues/411

Comment 1 Fedora Update System 2019-09-03 18:42:48 UTC

FEDORA-2019-d1f4da921c has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d1f4da921c

Comment 2 Fedora Update System 2019-09-04 04:58:17 UTC

torbrowser-launcher-0.3.2-7.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d1f4da921c

Comment 3 Fedora Update System 2019-09-04 10:51:27 UTC

torbrowser-launcher-0.3.2-7.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8db946311f

Comment 4 Fedora Update System 2019-09-08 02:59:10 UTC

torbrowser-launcher-0.3.2-7.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2019-09-28 00:01:38 UTC

torbrowser-launcher-0.3.2-7.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 AsciiWolf 2019-10-09 10:18:28 UTC

Tor Browser Launcher is still missing in GNOME Software on Fedora 30.

Comment 7 Fedora Update System 2019-10-09 14:04:04 UTC

FEDORA-2019-e7e18746ba has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e7e18746ba

Comment 8 Fedora Update System 2019-10-09 17:40:11 UTC

torbrowser-launcher-0.3.2-10.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e7e18746ba

Comment 9 Fedora Update System 2019-10-09 23:05:41 UTC

torbrowser-launcher-0.3.2-10.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c9ec7e36ce

Comment 10 Fedora Update System 2019-10-18 16:53:30 UTC

torbrowser-launcher-0.3.2-10.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2019-10-26 17:24:07 UTC

torbrowser-launcher-0.3.2-10.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 AsciiWolf 2019-10-26 18:34:39 UTC

Tor Browser Launcher is still missing in GNOME Software. I downloaded the latest package and checked the AppData file:

<id>org.torproject.torbrowser.desktop</id> - This is still wrong! The correct one should be: <id>torbrowser.desktop</id> (Same name as the actual desktop file.)

Comment 13 AsciiWolf 2019-10-26 18:38:35 UTC

Everything else seems to be correct. It's just the wrong id in AppData that I think is causing the issue.

(The legacy /usr/share/pixmaps icon path could be a problem as well, but I think that GNOME Software supports it.)

Comment 14 AsciiWolf 2019-10-27 11:14:41 UTC

Oh, I noticed one more thing: The "<component>" tag probably needs to be changed to "<component type="desktop-application">". The current one does not define that the AppData are for a desktop application.


So, to fix Tor Browser Launcher not showing in GNOME Software,

1. Change the "<id>org.torproject.torbrowser.desktop</id>" tag to "<id>torbrowser.desktop</id>",
2. Change the "<component>" tag to "<component type="desktop-application">".


Feel free to let me know, if you have any questions. Thanks!

Comment 15 Gwyn Ciesla 2019-10-27 15:14:56 UTC

Ok, thanks. Update coming.