Bug 1748527
| Summary: | Consider moving sip-api provides from python2-sip to python3-sip | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> |
| Component: | sip | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | kde-sig, mhroncok, rdieter, than, vstinner |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-09-16 16:00:37 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1729593 | ||
|
Description
Kevin Fenzi
2019-09-03 19:11:54 UTC
Consumers should probably move to the explicit python2-sip-api or python3-sip-api variants. The sip-api one is kept for historical reasons only... I'd prefer to remove them rather than change it. I'll think on it some more... then work to implement that changes needed (I think it's a little more complicated) I can change calibre easily enough.
diff --git a/calibre.spec b/calibre.spec
index 1a5d7e2..9092935 100644
--- a/calibre.spec
+++ b/calibre.spec
@@ -1,4 +1,4 @@
-%{?_sip_api:Requires: sip-api(%{_sip_api_major}) >= %{_sip_api}}
+%{?_sip_api:Requires: python3-sip-api(%{_sip_api_major}) >= %{_sip_api}}
%global __provides_exclude_from ^%{_libdir}/calibre/calibre/plugins/.*\.so$
@@ -6,7 +6,7 @@
Name: calibre
Version: 3.47.1
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: E-book converter and library manager
License: GPLv3
URL: https://calibre-ebook.com/
@@ -401,6 +401,9 @@ ln -s %{_jsdir}/mathjax %{_datadir}/calibre/viewer/
%{_datadir}/metainfo/*.appdata.xml
%changelog
+* Tue Sep 03 2019 Kevin Fenzi <kevin> - 3.47.1-2
+- Adjust sip requires to Require the python3-sip-api package.
+
* Mon Sep 02 2019 Kevin Fenzi <kevin> - 3.47.1-1
- Update 3.47.1. Fixes bug #1747848
I can push that for now, and we can adjust if you want to move the main sip-api?
Thing is, I dont think that's the right fix. You prob want sip-pyqt5 (or o e of it's provides) Arg, make that python3-sip-pyqt5 Hum, I don't see anything providing that? https://src.fedoraproject.org/rpms/sip/blob/master/f/sip.spec#_157 is where it's at, committing change to calibre now calibre fixed: https://src.fedoraproject.org/rpms/calibre/c/0a6632fccdbcc3949e3650d0beb2075e7d1c8ab6?branch=master qgis fixed: https://src.fedoraproject.org/rpms/qgis/c/858a2312dd642ba7511a11dceb1efca76ad59711?branch=master Those are the last two (according to repoquery), so I think I can follow-through with the threat to remove the non-namespaced python-sip subpkgs (for f31+) %changelog +* Mon Sep 16 2019 Rex Dieter <rdieter> - 4.19.18-7 +- drop no_namespace variant for f31+ I just got this from koschei: nothing provides python3-sip needed by python3-arcus-4.1.0-3.fc32.x86_64 What should I require instead? I assume python3-pyqt5-sip. OK, I only repoquery'd for python3-sip-api , that's probably what python3-arcus should depend on. I'll take a closer look. Arg, thouht this sounded familiar, seems upstream closed https://github.com/Ultimaker/libArcus/issues/76 without actually changing/fixing anything. :( So, our patch libArcus-3.5.1-PyQt5.sip.patch I *think* makes libarcus depend on namespaced python3-pyqt5-sip, I'll need to test that to confirm. Ok, this should do it, https://src.fedoraproject.org/rpms/libarcus/c/921f0316aa8b9710f2fe0088409172ac74fdae80 > Those are the last two (according to repoquery), so I think I can follow-through with the threat to remove the non-namespaced python-sip subpkgs (for f31+)
enki package is also affected by this change: see rhbz#1752766.
followup issues being tracked in bug #1753069 FEDORA-2019-c919b2ffda has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c919b2ffda libarcus-4.1.0-4.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c919b2ffda FEDORA-2019-1dc2365f05 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1dc2365f05 libarcus-4.1.0-5.fc31, libsavitar-4.1.0-4.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1dc2365f05 libarcus-4.1.0-5.fc31, libsavitar-4.1.0-4.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. |