Bug 174898
| Summary: | Review Request: perl-HTML-FillInForm | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | bkyoung <bkyoung> |
| Component: | Package Review | Assignee: | Thorsten Leemhuis (ignored mailbox) <bugzilla-sink> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mpeters |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://users.cwnet.com/~bkyoung/perl-HTML-FillInForm/perl-HTML-FillInForm-1.06-4.fc5.src.rpm | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-05-19 22:37:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
bkyoung
2005-12-03 17:04:25 UTC
Please change the URL to http://search.cpan.org/dist/HTML-FillInForm/ Please change Source0 to ftp://ftp.cpan.org/pub/CPAN/modules/by-module/HTML/HTML-FillInForm-%{version}.tar.gz Requires: perl-HTML-Parser normall you want to change that to Requires: perl(HTML::Parser) However - looking at the mock build.log - it seems that rpm picks that up itself, so the explicit requires should just by removed. Provides: perl(HTML::FillInForm) = 1.06 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 Requires: perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.6) perl(Carp) perl(HTML::Parser) >= 3.26 perl(integer) perl(strict) perl(vars) perl-HTML-Parser Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/perl-HTML-Fil lInForm-1.06-4.fc4-root-mockbuild rpmlint error on src.rpm: [mpeters@jerusalem result]$ rpmlint *.rpm W: perl-HTML-FillInForm strange-permission HTML-FillInForm-1.06.tar.gz 0600 You probably shour chmod 644 the src.tarball before building the src.rpm -=- * md5sum matches upstream * mock build clean (tested in FC4) * Appropriate License (GPL or Artistic) - matches tarball (as described in README file) * Written in American English * specfile name matches package * follows guidelines for naming of perl modules * follows example spec file for perl modules * proper and consistent use of macros * No un-necessary BuildRequires * cleanly installs / uninstalls (proper %files section) Fix the issues noted and I'll approve. >Please change the URL to >http://search.cpan.org/dist/HTML-FillInForm/ Done. >Please change Source0 to >ftp://ftp.cpan.org/pub/CPAN/modules/by-module/HTML/HTML-FillInForm-%{version}.tar.gz Done. >Requires: perl-HTML-Parser >normall you want to change that to >Requires: perl(HTML::Parser) >However - looking at the mock build.log - it seems that rpm picks that up >itself, so the explicit requires should just by removed. Removed. >Provides: perl(HTML::FillInForm) = 1.06 >Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 >rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 >Requires: perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.6) perl(Carp) >perl(HTML::Parser) >= 3.26 perl(integer) perl(strict) perl(vars) >perl-HTML-Parser >Checking for unpackaged file(s): /usr/lib/rpm/check-files >/var/tmp/perl-HTML-FillInForm-1.06-4.fc4-root-mockbuild >rpmlint error on src.rpm: >[mpeters@jerusalem result]$ rpmlint *.rpm >W: perl-HTML-FillInForm strange-permission HTML-FillInForm-1.06.tar.gz 0600 >You probably shour chmod 644 the src.tarball before building the src.rpm No problem, done. perl-HTML-FillInForm-1.06-6.fc5.noarch.rpm perl-HTML-FillInForm.spec perl-HTML-FillInForm.spec.6 Thanks, -Byron >Please change the URL to >http://search.cpan.org/dist/HTML-FillInForm/ Done. >Please change Source0 to >ftp://ftp.cpan.org/pub/CPAN/modules/by-module/HTML/HTML-FillInForm-%{version}.tar.gz Done. >Requires: perl-HTML-Parser >normall you want to change that to >Requires: perl(HTML::Parser) >However - looking at the mock build.log - it seems that rpm picks that up >itself, so the explicit requires should just by removed. Removed. >Provides: perl(HTML::FillInForm) = 1.06 >Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 >rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 >Requires: perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.6) perl(Carp) >perl(HTML::Parser) >= 3.26 perl(integer) perl(strict) perl(vars) >perl-HTML-Parser >Checking for unpackaged file(s): /usr/lib/rpm/check-files >/var/tmp/perl-HTML-FillInForm-1.06-4.fc4-root-mockbuild >rpmlint error on src.rpm: >[mpeters@jerusalem result]$ rpmlint *.rpm >W: perl-HTML-FillInForm strange-permission HTML-FillInForm-1.06.tar.gz 0600 >You probably shour chmod 644 the src.tarball before building the src.rpm No problem, done. perl-HTML-FillInForm-1.06-6.fc5.noarch.rpm perl-HTML-FillInForm.spec perl-HTML-FillInForm.spec.6 Thanks, -Byron Approved Any particular reason why this package is not yet imported and built ? It's been almost 4 months now with no import. I don't see you in the owners.list (with this e-mail anyway) so I'm going to assume I took this bug by mistake (as in you need a sponsor, which I can't do). Kicking back to FE-NEW |