Bug 1749107

With firefox-69.0-2.fc31.x86_64, the issue is gone. I guess this can be closed as soon as firefox-69 is submitted as update.

Yes, I disabled that for firefox-69.0-2 release.

Martin, why is this happening? The current F30 and F31 version are completely the same. Why does Firefox claim that the F30 version is newer?

As for the current fix, I assume it is this:
https://src.fedoraproject.org/rpms/firefox/c/b2802deb3dc56b6e8818a5b565414004377e6cdd?branch=master
Is it a good idea to just disable the warning dialog? That can burn us in the future. Also, there is a reason why the warning dialog is there - to protect user data. If we disable the protection, people can mess up their profiles by switching between Fedora-provided Firefox and external ones.

I propose this problem as a Beta blocker, because of the following criteria:
"For each one of the release-blocking package sets, it must be possible to successfully complete a direct upgrade from a fully updated, clean default installation of each of the last two stable Fedora releases with that package set installed. "
"The upgraded system must meet all release criteria."
https://fedoraproject.org/wiki/Fedora_31_Beta_Release_Criteria#Upgrade_requirements
"It must be possible to run the default web browser and a terminal application from all release-blocking desktop environments. "
https://fedoraproject.org/wiki/Basic_Release_Criteria#Required_applications

(In reply to Kamil Páral from comment #3)
> Martin, why is this happening? The current F30 and F31 version are
> completely the same. Why does Firefox claim that the F30 version is newer?

Because build-time is used as a criteria which may differ for various builds.
As we distribute the same Firefox versions on all Fedoras we're safe here.

> As for the current fix, I assume it is this:
> https://src.fedoraproject.org/rpms/firefox/c/
> b2802deb3dc56b6e8818a5b565414004377e6cdd?branch=master
> Is it a good idea to just disable the warning dialog? That can burn us in
> the future. Also, there is a reason why the warning dialog is there - to
> protect user data. If we disable the protection, people can mess up their
> profiles by switching between Fedora-provided Firefox and external ones.

If you install Firefox binaries from Mozilla you're expected to know what you're doing
and you should create a new profile for it.
Also Mozilla builds have the profile check active.

> I propose this problem as a Beta blocker, because of the following criteria:
> "For each one of the release-blocking package sets, it must be possible to
> successfully complete a direct upgrade from a fully updated, clean default
> installation of each of the last two stable Fedora releases with that
> package set installed. "
> "The upgraded system must meet all release criteria."
> https://fedoraproject.org/wiki/
> Fedora_31_Beta_Release_Criteria#Upgrade_requirements
> "It must be possible to run the default web browser and a terminal
> application from all release-blocking desktop environments. "
> https://fedoraproject.org/wiki/Basic_Release_Criteria#Required_applications

I'm not sure what problem - the check is here or the check is disabled?

Also frozen Fedora Beta image can contain older Firefox version than any fully
up to date Fedora release if new Firefox version is released after
Fedora Beta release.

Ideally, firefox would use a version comparison. Looking at build time
is only useful for upstream (and even there it's questionable, because they
do have e.g. nightly builds and non-nightly builds and things are not always
built strictly chronologically). In a scenario where people might installs builds
with different versions from different sources, or where stable point upgrades are
built, a check based on build time is not useful at all.

As Zbigniew mentioned above, build-time comparison is really silly. If that can't be easily changed, I agree that we can't do much but to disable the downgrade protection (and ideally request changes upstream).

> I'm not sure what problem - the check is here or the check is disabled?

That blocker proposal is not related to the rest of our discussion. This bug is proposed as a blocker, because currently when you upgrade F30 to F31, your Firefox won't start properly. That will be fixed once firefox-69.0-2 is stable in F31. For that you need to go through Bodhi, and since we're currently frozen, you either need a blocker or a freeze exception approval. Thus this proposal :)

Yes, the version check sounds reasonable, I'll file a new bug for it.

(In reply to Martin Stransky from comment #7)
> Yes, the version check sounds reasonable, I'll file a new bug for it.

Filed as Bug 1749441.

FEDORA-2019-f91860efa3 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-f91860efa3

I edited the firefox update to mark this bug as fixed.

+1 blocker per Basic criterion "It must be possible to run the default web browser and a terminal application from all release-blocking desktop environments" and Beta criterion "For each one of the release-blocking package sets, it must be possible to successfully complete a direct upgrade from a fully updated, clean default installation of each of the last two stable Fedora releases with that package set installed...The upgraded system must meet all release criteria."

+1 blocker for the same reasons as Adam in comment 11.

Discussed during the 2019-09-09 blocker review meeting: [0]

The decision to classify this bug as an "AcceptedBlocker" was made as it violates the following criterion:

"upgraded systems must meet release criteria" criterion combined with the "desktop browser must work"

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2019-09-09/f31-blocker-review.2019-09-09-16.00.txt

firefox-69.0-2.fc31, nspr-4.22.0-1.fc31, nss-3.46.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.