Bug 1749202

Summary:	[downstream clone - 4.3.7] "Field 'foo' can not be updated when status is 'Up'" in engine.log when listing 'NEXT_RUN' configuration snapshot VMs
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	RHV bug bot <rhv-bugzilla-bot>
Component:	ovirt-engine	Assignee:	Lucia Jelinkova <ljelinko>
Status:	CLOSED ERRATA	QA Contact:	Beni Pelled <bpelled>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	bugs, fschmid, jortialc, rbarry, Rhev-m-bugs, rhodain, sgratch, sigbjorn
Target Milestone:	ovirt-4.3.7	Keywords:	Rebase, ZStream
Target Release:	---	Flags:	lsvaty: testing_plan_complete-
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	1742924	Environment:
Last Closed:	2019-12-12 10:36:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1742924
Bug Blocks:

Description RHV bug bot 2019-09-05 06:53:09 UTC

+++ This bug is an upstream to downstream clone. The original bug is: +++
+++   bug 1742924 +++
======================================================================

Description of problem:
VMs with 'NEXT_RUN' configuration snapshots cause engine.log lines like 

WARN  [org.ovirt.engine.core.utils.ObjectIdentityChecker] (default task-123) [some UUID] Field 'foo' can not be updated when status is 'Up'

not only once when VM configuration change is entered but also whenever VM list is refreshed subsequently (and maybe other occasions) in Administration Portal

Version-Release number of selected component (if applicable):
ovirt-engine-4.3.5.5-1.el7.noarch

How reproducible:
change property of VM that cannot be applied immediately
refresh VM list

Steps to Reproduce:
1. change property of VM that cannot be applied immediately
2. refresh VM list
3. look at engine.log

Actual results:
set of lines like 

WARN  [org.ovirt.engine.core.utils.ObjectIdentityChecker] (default task-123) [some UUID] Field 'foo' can not be updated when status is 'Up'

is visible in engine.log

Expected results:
no logs relating to VMs with 'NEXT_RUN' configuration snapshots visible in engine.log


Additional info:
I saw this in two oVirt installations that were upgraded from 4.3.3 to 4.3.5
when there are a lot of VMs with 'NEXT_RUN' configuration snapshots (like in the aftermath of a major version upgrade where every VM has to upgrade compatibility version) this behaviour can cause considerable load on the engine host and engine.log size can grow rapidly when using the Administration Portal
I'm on holiday next week and can't provide further information until 2019-08-26, but I think the situation is rather obvious and the bug was confirmed on the mailing list

(Originally by matthias.leopold)

Comment 1 RHV bug bot 2019-09-05 06:53:11 UTC

Hi,

I have already asked in the mailing list, if there will be a patch available also for 4.3.X?
But no answer for over one week now.

It would be impossible for me to upgrade to 4.3.5 until this problem is fixed.

If you don't want to release an official patch, then please give me a howto to fix that manually.

BR Florian

(Originally by fschmid)

Comment 2 RHV bug bot 2019-09-05 06:53:13 UTC

Hi,

are there any news on this, if this patch may be available earlier than 4.4?
I see, that there is already a patch available, but not merged!

BR Florian

(Originally by fschmid)

Comment 3 Florian Schmid 2019-09-09 08:36:47 UTC

Hi,

thank you very much!

You all are doing a great job!

BR Florian

Comment 5 RHV bug bot 2019-11-01 09:31:57 UTC

INFO: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Tag 'ovirt-engine-4.3.7.1' doesn't contain patch 'https://gerrit.ovirt.org/102838']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.3.7.1

For more info please contact: rhv-devops

Comment 6 Sandro Bonazzola 2019-11-13 13:32:05 UTC

the fix was done with $ git tag --contains 12bd5cb1fe7c95e29b4065fca968913722fe9eaa
ovirt-engine-4.3.6.6
ovirt-engine-4.3.6.7
ovirt-engine-4.3.7.0
ovirt-engine-4.3.7.1

So the fix is already included in release oVirt 4.3.6.

Comment 7 Beni Pelled 2019-11-13 14:06:22 UTC

Verified on:
- RHV 4.3.7.0-0.1.el7

Verification steps:

1. Create VM.
2. Start the VM.
3. Edit the VM and add 'Second Device' under 'Boot Options > Boot Sequence'.
4. Confirm the message that says the restart is needed for the update to be applied.
4. Refresh the vm list and look for any WARN/ObjectIdentityChecker logs on /var/log/ovirt-engine/engine.log as mentioned above.

Result:

- No WARN/ObjectIdentityChecker logs or any other logs on /var/log/ovirt-engine/engine.log when refreshing the vm list.

Comment 9 errata-xmlrpc 2019-12-12 10:36:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4229