Bug 1749847

Error seen on Fedora 31.

Running uname -a: Linux hostname.domain 5.3.13-300.fc31.x86_64 #1 SMP Mon Nov 25 17:25:25 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Running journalctl -b -p 3| less shows below:

usr/lib/udev/rules.d/99-vmware-scsi-udev.rules:5 Invalid value "/bin/sh -c 'echo 180 >/sys$DEVPATH/device/timeout'" for RUN (char 27: invalid substitution type), ignoring, 
but please fix it.
/usr/lib/udev/rules.d/99-vmware-scsi-udev.rules:6 Invalid value "/bin/sh -c 'echo 180 >/sys$DEVPATH/device/timeout'" for RUN (char 27: invalid substitution type), ignoring, 
but please fix it.

Any way to troubleshoot udev? By comment it out?

(In reply to Vanoywj from comment #1)
> Any way to troubleshoot udev? By comment it out?

Could you please take a backup of existing /usr/lib/udev/rules.d/99-vmware-scsi-udev.rules file and in the main /usr/lib/udev/rules.d/99-vmware-scsi-udev.rule file try replacing $DEVPATH with $env{DEVPATH}? Please let me know if the problem gets fixed. Thanks!

I need to double check later but if I remember right the fix is to duplicate the percent sign.

s/percent/dollar:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5448

Thanks Julian. I will check on that.

(In reply to Ravindra Kumar from comment #2)
> (In reply to Vanoywj from comment #1)
> > Any way to troubleshoot udev? By comment it out?
> 
> Could you please take a backup of existing
> /usr/lib/udev/rules.d/99-vmware-scsi-udev.rules file and in the main
> /usr/lib/udev/rules.d/99-vmware-scsi-udev.rule file try replacing $DEVPATH
> with $env{DEVPATH}? Please let me know if the problem gets fixed. Thanks!

Could you please also try what Julian suggested? Basically, try replacing $DEVPATH with $$DEVPATH and let us know the result.

I can confirm that doubling the dollar sign fixes the problem. Before:

gru 15 11:09:46 napoleon2 systemd-udevd[135922]: Using default interface naming scheme 'v243'.
gru 15 11:09:46 napoleon2 systemd-udevd[135920]: Using default interface naming scheme 'v243'.
gru 15 11:09:46 napoleon2 systemd-udevd[135935]: Using default interface naming scheme 'v243'.
gru 15 11:09:46 napoleon2 systemd-udevd[135924]: Using default interface naming scheme 'v243'.
gru 15 11:10:14 napoleon2 systemd-udevd[744]: /etc/udev/rules.d/10-atmel-dfu.rules:1 Invalid key/value pair, ignoring.
gru 15 11:10:14 napoleon2 systemd-udevd[744]: /etc/udev/rules.d/10-atmel-dfu.rules:2 Invalid key/value pair, ignoring.
gru 15 11:10:14 napoleon2 systemd-udevd[744]: /usr/lib/udev/rules.d/65-md-incremental.rules:28 Invalid value "/sbin/mdadm -I $env{DEVNAME} --export $devnode --offroot ${DEVLINKS}" for IMPORT (char 58: invalid substitution type), ignoring, but please fix it.
gru 15 11:10:14 napoleon2 systemd-udevd[744]: /usr/lib/udev/rules.d/99-vmware-scsi-udev.rules:5 Invalid value "/bin/sh -c 'echo 180 >/sys$DEVPATH/device/timeout'" for RUN (char 27: invalid substitution type), ignoring, but please fix it.
gru 15 11:10:14 napoleon2 systemd-udevd[744]: /usr/lib/udev/rules.d/99-vmware-scsi-udev.rules:6 Invalid value "/bin/sh -c 'echo 180 >/sys$DEVPATH/device/timeout'" for RUN (char 27: invalid substitution type), ignoring, but please fix it.

After:

gru 15 11:10:14 napoleon2 systemd-udevd[136519]: Using default interface naming scheme 'v243'.
gru 15 11:10:14 napoleon2 systemd-udevd[136530]: Using default interface naming scheme 'v243'.
gru 15 11:10:15 napoleon2 systemd-udevd[136543]: Using default interface naming scheme 'v243'.
gru 15 11:10:15 napoleon2 systemd-udevd[136536]: Using default interface naming scheme 'v243'.
gru 15 11:12:01 napoleon2 systemd-udevd[744]: /etc/udev/rules.d/10-atmel-dfu.rules:1 Invalid key/value pair, ignoring.
gru 15 11:12:01 napoleon2 systemd-udevd[744]: /etc/udev/rules.d/10-atmel-dfu.rules:2 Invalid key/value pair, ignoring.
gru 15 11:12:01 napoleon2 systemd-udevd[744]: /usr/lib/udev/rules.d/65-md-incremental.rules:28 Invalid value "/sbin/mdadm -I $env{DEVNAME} --export $devnode --offroot ${DEVLINKS}" for IMPORT (char 58: invalid substitution type), ignoring, but please fix it.

As the file needing fix comes from upstream, I have created a PR there:
https://github.com/vmware/open-vm-tools/pull/394

This is fix: https://github.com/vmware/open-vm-tools/commit/f1dab8ded45aaaa4b6993a4d96d0aefc700f1796

FEDORA-2020-7ffbe344e0 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7ffbe344e0

Here is Fedora 30 update for this - https://bodhi.fedoraproject.org/updates/FEDORA-2020-6fd1742ae6.

open-vm-tools-11.0.5-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6fd1742ae6

open-vm-tools-11.0.5-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7ffbe344e0

open-vm-tools-11.0.5-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

open-vm-tools-11.0.5-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-63fe61753a

open-vm-tools-11.0.5-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.