Bug 1749861

Summary:	gstreamer-vaapi patch required
Product:	[Fedora] Fedora	Reporter:	Michael Catanzaro <mcatanzaro>
Component:	gstreamer1-vaapi	Assignee:	Simon Farnsworth <simon>
Status:	CLOSED CANTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	30	CC:	fraph24, kwizart, moez.roy, simon, wtaymans
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-12 19:27:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Catanzaro 2019-09-06 15:21:41 UTC

Hi,

The gstreamer1-vaapi package needs this patch:

https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/merge_requests/72.patch

or it will break AMD graphics users.

Details:

https://mail.gnome.org/archives/distributor-list/2019-September/msg00000.html

Comment 1 Simon Farnsworth 2019-09-09 12:00:04 UTC

To confirm, the underlying issue is https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/137 and when that is fixed I'll be able to drop this patch? Or has the patch gone upstream already, and this is just requesting that we backport it for the benefit of everyone waiting for a fixed gstreamer-vaapi to be released?

Comment 2 Michael Catanzaro 2019-09-09 12:53:18 UTC

The patch went upstream shortly after I reported this bug, so yes you should be able to drop it after the next gstreamer-vaapi release (probably 1.16.1).

Comment 3 Fedora Update System 2019-10-07 10:58:52 UTC

FEDORA-2019-4d639f8e15 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-4d639f8e15

Comment 4 Fedora Update System 2019-10-08 21:41:59 UTC

gstreamer1-vaapi-1.16.1-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4d639f8e15

Comment 5 Simon Farnsworth 2019-10-12 19:27:27 UTC

This bug was reported against 1.16.1, which already had the requested patch applied.

Comment 6 Michael Catanzaro 2019-10-13 16:33:48 UTC

Well this bug reports predates 1.16.1, but yes this should be closed now.

Comment 7 Michael Catanzaro 2019-10-16 01:42:10 UTC

Er hey Simon, the package was left in a bad state (patch committed to git but not applied) and should be cleaned up: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4d639f8e15#comment-1085683

Comment 8 Nicolas Chauvet (kwizart) 2019-10-16 06:35:35 UTC

I confirm that applying the patch fail as the patch is already applied.
Cleaned up the git module and withdrawn the package update.
(there is no functional change, so no need to issue a new updates for f31).