Bug 1750179

Summary:	Review Request: git-remote-gcrypt - GNU Privacy Guard-encrypted git remote
Product:	[Fedora] Fedora	Reporter:	Dusty Mabe <dustymabe>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-09 16:52:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dusty Mabe 2019-09-08 21:55:36 UTC

Spec URL: https://github.com/dustymabe/git-remote-gcrypt-rpm/blob/master/git-remote-gcrypt.spec
SRPM URL: https://github.com/dustymabe/git-remote-gcrypt-rpm/blob/master/git-remote-gcrypt-1.2-1.fc31.src.rpm
Fedora Account System Username: dustymabe
Description: 

This lets git store git repositories in encrypted form.            
It supports storing repositories on rsync or sftp servers.         
It can also store the encrypted git repository inside a remote git 
repository. All the regular git commands like git push and git pull
can be used to operate on such an encrypted repository.            
                                                                   
The aim is to provide confidential, authenticated git storage and  
collaboration using typical untrusted file hosts or services.      




NOTE: The spec file was adapted from the spec file in the upstream code repository [1]. I did not change the spec file much with the intentions of
submitting my minimal changes back upstream.

[1] https://git.spwhitton.name/git-remote-gcrypt/tree/redhat/git-remote-gcrypt.spec

Comment 1 Dusty Mabe 2019-09-08 21:56:54 UTC

I also created a copr for this: http://copr.fedorainfracloud.org/coprs/dustymabe/git-remote-gcrypt/

Comment 2 Robert-André Mauchin 🐧 2019-09-19 15:23:32 UTC

 - Not useful for a noarch package:

%global debug_package %{nil}

 - /usr/bin/%{name} → %{_bindir}/%{name}

 - Man pages should not be marked as %doc

 - man pages extension should be globbed as the compression may change in the future. 

 - the man page should be installed unzipped. The compression will be handled by the rpm build process.

 - %doc /usr/share/man/man1/%{name}.1.gz → %{_mandir}/man1/%{name}.1*

 - You should provide the doc files:

%doc CHANGELOG CONTRIBUTING.rst README.rst

Comment 3 Dusty Mabe 2019-09-19 21:36:22 UTC

Thanks for the review!

Updated based on comments:

Spec URL: https://github.com/dustymabe/git-remote-gcrypt-rpm/blob/master/git-remote-gcrypt.spec
SRPM URL: https://github.com/dustymabe/git-remote-gcrypt-rpm/blob/master/git-remote-gcrypt-1.2-1.fc31.src.rpm

Comment 4 Dusty Mabe 2019-09-19 21:37:18 UTC

If you'd like you can review the changes by viewing the commits on the master branch of the GH repo: https://github.com/dustymabe/git-remote-gcrypt-rpm/commits/master

Comment 5 Dusty Mabe 2019-09-22 13:43:54 UTC

Any other fixes I need to make?

Comment 6 Robert-André Mauchin 🐧 2019-09-22 18:54:14 UTC

 - Group is not used in Fedora.

Package approved.

Comment 7 Dusty Mabe 2019-09-23 16:58:00 UTC

ok I'll try to remove the group stuff. Thanks!

Comment 8 Fedora Update System 2019-09-30 04:06:45 UTC

FEDORA-2019-30deef4773 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-30deef4773

Comment 9 Fedora Update System 2019-09-30 04:07:45 UTC

FEDORA-2019-820dc59315 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-820dc59315

Comment 10 Fedora Update System 2019-10-01 01:01:39 UTC

git-remote-gcrypt-1.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-30deef4773

Comment 11 Fedora Update System 2019-10-01 03:06:17 UTC

git-remote-gcrypt-1.2-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-820dc59315

Comment 12 Fedora Update System 2019-10-09 16:52:51 UTC

git-remote-gcrypt-1.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2019-10-26 17:20:30 UTC

git-remote-gcrypt-1.2-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.