Bug 1750499

Thank you so much Guido for bringing this back up!
Could you re-add the previous %changelog so we don't lose history?

Spec URL: https://tartina.fedorapeople.org/ladspa-swh-plugins.spec
SRPM URL: https://tartina.fedorapeople.org/ladspa-swh-plugins-0.4.17-4.fc32.src.rpm

Restored most changelog history, I didn't restore some very old bad formatted lines.

Running automated checks.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Package APPROVED.

Issues:
=======

Shuld be fixed:

 - no %check
 - replace %define with %global


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verified they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* NTP License", "Expat
     License", "GNU Lesser General Public License (v2.1 or later)", "GPL
     (v2 or later) (with incorrect FSF address)". 201 files have unknown
     license.
     The MIT file is nto shipped. The LGPL thing gets beaten by GPL.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[-]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[!]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define pkgname swh-plugins
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[!]: Package should not use obsolete m4 macros
     Note: Some obsoleted macros found, see the attachment.
     See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ladspa-swh-plugins-0.4.17-4.fc32.x86_64.rpm
          ladspa-swh-plugins-debuginfo-0.4.17-4.fc32.x86_64.rpm
          ladspa-swh-plugins-debugsource-0.4.17-4.fc32.x86_64.rpm
          ladspa-swh-plugins-0.4.17-4.fc32.src.rpm
ladspa-swh-plugins.x86_64: E: incorrect-fsf-address /usr/share/licenses/ladspa-swh-plugins/COPYING
4 packages and 0 specfiles checked; 1 errors, 0 warnings.

OK.


Rpmlint (debuginfo)
-------------------
Checking: ladspa-swh-plugins-debuginfo-0.4.17-4.fc32.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


OK.


Rpmlint (installed packages)
----------------------------
ladspa-swh-plugins-debugsource.x86_64: W: invalid-url URL: http://plugin.org.uk/ <urlopen error [Errno -2] Name or service not known>
ladspa-swh-plugins.x86_64: W: invalid-url URL: http://plugin.org.uk/ <urlopen error [Errno -2] Name or service not known>
ladspa-swh-plugins.x86_64: E: incorrect-fsf-address /usr/share/licenses/ladspa-swh-plugins/COPYING
ladspa-swh-plugins-debuginfo.x86_64: W: invalid-url URL: http://plugin.org.uk/ <urlopen error [Errno -2] Name or service not known>
3 packages and 0 specfiles checked; 1 errors, 3 warnings.

OK.


Unversioned so-files
--------------------
ladspa-swh-plugins: /usr/lib64/ladspa/alias_1407.so
ladspa-swh-plugins: /usr/lib64/ladspa/allpass_1895.so
ladspa-swh-plugins: /usr/lib64/ladspa/am_pitchshift_1433.so
ladspa-swh-plugins: /usr/lib64/ladspa/amp_1181.so
ladspa-swh-plugins: /usr/lib64/ladspa/analogue_osc_1416.so
ladspa-swh-plugins: /usr/lib64/ladspa/bandpass_a_iir_1893.so
ladspa-swh-plugins: /usr/lib64/ladspa/bandpass_iir_1892.so
ladspa-swh-plugins: /usr/lib64/ladspa/bode_shifter_1431.so
ladspa-swh-plugins: /usr/lib64/ladspa/bode_shifter_cv_1432.so
ladspa-swh-plugins: /usr/lib64/ladspa/butterworth_1902.so
ladspa-swh-plugins: /usr/lib64/ladspa/chebstortion_1430.so
ladspa-swh-plugins: /usr/lib64/ladspa/comb_1190.so
ladspa-swh-plugins: /usr/lib64/ladspa/comb_1887.so
ladspa-swh-plugins: /usr/lib64/ladspa/comb_splitter_1411.so
ladspa-swh-plugins: /usr/lib64/ladspa/const_1909.so
ladspa-swh-plugins: /usr/lib64/ladspa/crossover_dist_1404.so
ladspa-swh-plugins: /usr/lib64/ladspa/dc_remove_1207.so
ladspa-swh-plugins: /usr/lib64/ladspa/decay_1886.so
ladspa-swh-plugins: /usr/lib64/ladspa/decimator_1202.so
ladspa-swh-plugins: /usr/lib64/ladspa/declip_1195.so
ladspa-swh-plugins: /usr/lib64/ladspa/delay_1898.so
ladspa-swh-plugins: /usr/lib64/ladspa/delayorama_1402.so
ladspa-swh-plugins: /usr/lib64/ladspa/diode_1185.so
ladspa-swh-plugins: /usr/lib64/ladspa/divider_1186.so
ladspa-swh-plugins: /usr/lib64/ladspa/dj_eq_1901.so
ladspa-swh-plugins: /usr/lib64/ladspa/dj_flanger_1438.so
ladspa-swh-plugins: /usr/lib64/ladspa/dyson_compress_1403.so
ladspa-swh-plugins: /usr/lib64/ladspa/fad_delay_1192.so
ladspa-swh-plugins: /usr/lib64/ladspa/fast_lookahead_limiter_1913.so
ladspa-swh-plugins: /usr/lib64/ladspa/flanger_1191.so
ladspa-swh-plugins: /usr/lib64/ladspa/fm_osc_1415.so
ladspa-swh-plugins: /usr/lib64/ladspa/foldover_1213.so
ladspa-swh-plugins: /usr/lib64/ladspa/foverdrive_1196.so
ladspa-swh-plugins: /usr/lib64/ladspa/freq_tracker_1418.so
ladspa-swh-plugins: /usr/lib64/ladspa/gate_1410.so
ladspa-swh-plugins: /usr/lib64/ladspa/giant_flange_1437.so
ladspa-swh-plugins: /usr/lib64/ladspa/gong_1424.so
ladspa-swh-plugins: /usr/lib64/ladspa/gong_beater_1439.so
ladspa-swh-plugins: /usr/lib64/ladspa/gsm_1215.so
ladspa-swh-plugins: /usr/lib64/ladspa/gverb_1216.so
ladspa-swh-plugins: /usr/lib64/ladspa/hard_limiter_1413.so
ladspa-swh-plugins: /usr/lib64/ladspa/harmonic_gen_1220.so
ladspa-swh-plugins: /usr/lib64/ladspa/hermes_filter_1200.so
ladspa-swh-plugins: /usr/lib64/ladspa/highpass_iir_1890.so
ladspa-swh-plugins: /usr/lib64/ladspa/hilbert_1440.so
ladspa-swh-plugins: /usr/lib64/ladspa/imp_1199.so
ladspa-swh-plugins: /usr/lib64/ladspa/impulse_1885.so
ladspa-swh-plugins: /usr/lib64/ladspa/inv_1429.so
ladspa-swh-plugins: /usr/lib64/ladspa/karaoke_1409.so
ladspa-swh-plugins: /usr/lib64/ladspa/latency_1914.so
ladspa-swh-plugins: /usr/lib64/ladspa/lcr_delay_1436.so
ladspa-swh-plugins: /usr/lib64/ladspa/lowpass_iir_1891.so
ladspa-swh-plugins: /usr/lib64/ladspa/ls_filter_1908.so
ladspa-swh-plugins: /usr/lib64/ladspa/matrix_ms_st_1421.so
ladspa-swh-plugins: /usr/lib64/ladspa/matrix_spatialiser_1422.so
ladspa-swh-plugins: /usr/lib64/ladspa/matrix_st_ms_1420.so
ladspa-swh-plugins: /usr/lib64/ladspa/mbeq_1197.so
ladspa-swh-plugins: /usr/lib64/ladspa/mod_delay_1419.so
ladspa-swh-plugins: /usr/lib64/ladspa/multivoice_chorus_1201.so
ladspa-swh-plugins: /usr/lib64/ladspa/notch_iir_1894.so
ladspa-swh-plugins: /usr/lib64/ladspa/phasers_1217.so
ladspa-swh-plugins: /usr/lib64/ladspa/pitch_scale_1193.so
ladspa-swh-plugins: /usr/lib64/ladspa/pitch_scale_1194.so
ladspa-swh-plugins: /usr/lib64/ladspa/plate_1423.so
ladspa-swh-plugins: /usr/lib64/ladspa/pointer_cast_1910.so
ladspa-swh-plugins: /usr/lib64/ladspa/rate_shifter_1417.so
ladspa-swh-plugins: /usr/lib64/ladspa/retro_flange_1208.so
ladspa-swh-plugins: /usr/lib64/ladspa/revdelay_1605.so
ladspa-swh-plugins: /usr/lib64/ladspa/ringmod_1188.so
ladspa-swh-plugins: /usr/lib64/ladspa/satan_maximiser_1408.so
ladspa-swh-plugins: /usr/lib64/ladspa/sc1_1425.so
ladspa-swh-plugins: /usr/lib64/ladspa/sc2_1426.so
ladspa-swh-plugins: /usr/lib64/ladspa/sc3_1427.so
ladspa-swh-plugins: /usr/lib64/ladspa/sc4_1882.so
ladspa-swh-plugins: /usr/lib64/ladspa/sc4m_1916.so
ladspa-swh-plugins: /usr/lib64/ladspa/se4_1883.so
ladspa-swh-plugins: /usr/lib64/ladspa/shaper_1187.so
ladspa-swh-plugins: /usr/lib64/ladspa/sifter_1210.so
ladspa-swh-plugins: /usr/lib64/ladspa/sin_cos_1881.so
ladspa-swh-plugins: /usr/lib64/ladspa/single_para_1203.so
ladspa-swh-plugins: /usr/lib64/ladspa/sinus_wavewrapper_1198.so
ladspa-swh-plugins: /usr/lib64/ladspa/smooth_decimate_1414.so
ladspa-swh-plugins: /usr/lib64/ladspa/split_1406.so
ladspa-swh-plugins: /usr/lib64/ladspa/step_muxer_1212.so
ladspa-swh-plugins: /usr/lib64/ladspa/surround_encoder_1401.so
ladspa-swh-plugins: /usr/lib64/ladspa/svf_1214.so
ladspa-swh-plugins: /usr/lib64/ladspa/tape_delay_1211.so
ladspa-swh-plugins: /usr/lib64/ladspa/transient_1206.so
ladspa-swh-plugins: /usr/lib64/ladspa/triple_para_1204.so
ladspa-swh-plugins: /usr/lib64/ladspa/valve_1209.so
ladspa-swh-plugins: /usr/lib64/ladspa/valve_rect_1405.so
ladspa-swh-plugins: /usr/lib64/ladspa/vocoder_1337.so
ladspa-swh-plugins: /usr/lib64/ladspa/vynil_1905.so
ladspa-swh-plugins: /usr/lib64/ladspa/wave_terrain_1412.so
ladspa-swh-plugins: /usr/lib64/ladspa/xfade_1915.so
ladspa-swh-plugins: /usr/lib64/ladspa/zm1_1428.so

OK.

Source checksums
----------------
https://github.com/swh/ladspa/archive/v0.4.17/ladspa-swh-plugins-0.4.17.tar.gz :
  CHECKSUM(SHA256) this package     : d1b090feec4c5e8f9605334b47faaad72db7cc18fe91d792b9161a9e3b821ce7
  CHECKSUM(SHA256) upstream package : d1b090feec4c5e8f9605334b47faaad72db7cc18fe91d792b9161a9e3b821ce7


Requires
--------
ladspa-swh-plugins (rpmlib, GLIBC filtered):
    ladspa
    libc.so.6()(64bit)
    libfftw3f.so.3()(64bit)
    libgsm.so.1()(64bit)
    libm.so.6()(64bit)
    librt.so.1()(64bit)
    rtld(GNU_HASH)

ladspa-swh-plugins-debuginfo (rpmlib, GLIBC filtered):

ladspa-swh-plugins-debugsource (rpmlib, GLIBC filtered):



Provides
--------
ladspa-swh-plugins:
    ladspa-swh-plugins
    ladspa-swh-plugins(x86-64)

ladspa-swh-plugins-debuginfo:
    debuginfo(build-id)
    ladspa-swh-plugins-debuginfo
    ladspa-swh-plugins-debuginfo(x86-64)

ladspa-swh-plugins-debugsource:
    ladspa-swh-plugins-debugsource
    ladspa-swh-plugins-debugsource(x86-64)

Spec URL: https://tartina.fedorapeople.org/ladspa-swh-plugins.spec
SRPM URL: https://tartina.fedorapeople.org/ladspa-swh-plugins-0.4.17-5.fc32.src.rpm

Fixed %define and FSF address; I will send FSF address patch upstream ASAP.

This package does not have a test suite, is %check mandatory?

By the way thanks for your review.

> Fixed ... FSF address; I will send FSF address patch upstream ASAP.

Good to send the patch upstream, but please don't apply it in Fedora yet. Technically you cannot change the license without upstream's approval.


> This package does not have a test suite, is %check mandatory?

Not at all, it is a SHOULD.


> By the way thanks for your review.

Glad I could help.

FEDORA-2019-bd89934432 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-bd89934432

FEDORA-2019-781952f8b3 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-781952f8b3

ladspa-swh-plugins-0.4.17-5.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-781952f8b3

ladspa-swh-plugins-0.4.17-5.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-bd89934432

ladspa-swh-plugins-0.4.17-5.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

ladspa-swh-plugins-0.4.17-5.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.